From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82B42A046B for ; Wed, 24 Jul 2019 03:36:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD7511C0D5; Wed, 24 Jul 2019 03:36:19 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E918F1C0CC for ; Wed, 24 Jul 2019 03:36:16 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 18:36:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,300,1559545200"; d="scan'208";a="174726290" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.185]) by orsmga006.jf.intel.com with ESMTP; 23 Jul 2019 18:36:15 -0700 Date: Wed, 24 Jul 2019 16:17:37 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org Message-ID: <20190724081737.GA72232@intel.com> References: <1563929545-25010-1-git-send-email-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1563929545-25010-1-git-send-email-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1] net/ice: remove unnecessary type cast in rx/tx ring setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/24, Haiyue Wang wrote: >The memzone's start virtual address pointer (addr) is of type void *, >no need to add type cast. > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c >index 3353f23..0282b53 100644 >--- a/drivers/net/ice/ice_rxtx.c >+++ b/drivers/net/ice/ice_rxtx.c >@@ -664,7 +664,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev, > memset(rz->addr, 0, ring_size); > > rxq->rx_ring_dma = rz->iova; >- rxq->rx_ring = (union ice_rx_desc *)rz->addr; >+ rxq->rx_ring = rz->addr; > > #ifdef RTE_LIBRTE_ICE_RX_ALLOW_BULK_ALLOC > len = (uint16_t)(nb_desc + ICE_RX_MAX_BURST); >@@ -882,7 +882,7 @@ ice_tx_queue_setup(struct rte_eth_dev *dev, > txq->tx_deferred_start = tx_conf->tx_deferred_start; > > txq->tx_ring_dma = tz->iova; >- txq->tx_ring = (struct ice_tx_desc *)tz->addr; >+ txq->tx_ring = tz->addr; > > /* Allocate software ring */ > txq->sw_ring = >-- >2.7.4 > Reviewed-by: Xiaolong Ye