From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A52D1A046B for ; Wed, 24 Jul 2019 17:50:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 321B41C217; Wed, 24 Jul 2019 17:50:51 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 96C6D1C211; Wed, 24 Jul 2019 17:50:49 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 08:50:48 -0700 X-IronPort-AV: E=Sophos;i="5.64,303,1559545200"; d="scan'208";a="163884057" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 08:50:46 -0700 Date: Wed, 24 Jul 2019 16:50:43 +0100 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org, thomas@monjalon.net, harry.van.haaren@intel.com, stable@dpdk.org Message-ID: <20190724155042.GC1608@bricha3-MOBL.ger.corp.intel.com> References: <806101b6235bd6e8534114898d4de7ea1cb38cac.1563983246.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <806101b6235bd6e8534114898d4de7ea1cb38cac.1563983246.git.anatoly.burakov@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] test: enable installing test app with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 24, 2019 at 04:47:31PM +0100, Anatoly Burakov wrote: > Currently, the test app is not being installed by default when > built and installed with meson build system. Fix that to enable > installation of the test app alongside other DPDK apps. > > Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") > Cc: harry.van.haaren@intel.com > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > --- > app/test/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 1834897bf..c50b20275 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -359,7 +359,7 @@ dpdk_test = executable('dpdk-test', > dependencies: test_dep_objs, > c_args: [cflags, '-DALLOW_EXPERIMENTAL_API'], > install_rpath: driver_install_path, > - install: false) > + install: true) > I see no major reason not to have it installed - if anyone does not want the test app, they can disable it completely using the meson option "tests". Therefore: Acked-by: Bruce Richardson