From: Ye Xiaolong <xiaolong.ye@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/8] net/af_xdp: remove unused Tx counter
Date: Fri, 26 Jul 2019 09:33:23 +0800 [thread overview]
Message-ID: <20190726013323.GA25993@intel.com> (raw)
In-Reply-To: <CAJFAV8yQyBaD+b4n0BTV+kMXuqBQJif9nTmh_R1u6-5C1C=yPg@mail.gmail.com>
On 07/25, David Marchand wrote:
>On Thu, Jul 25, 2019 at 5:49 PM Ye Xiaolong <xiaolong.ye@intel.com> wrote:
>>
>> On 07/25, David Marchand wrote:
>> >This Tx counter is now unused.
>> >
>> >Fixes: 10edf857fde4 ("net/af_xdp: make reserve/submit peek/release consistent")
>>
>> err_pkts seems not introduced by this commit?
>
>This commit removed the only place where it was used.
>
Got it, make sense.
Thanks,
Xiaolong
>>
>> >
>> >Signed-off-by: David Marchand <david.marchand@redhat.com>
>> >---
>> > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 --
>> > 1 file changed, 2 deletions(-)
>> >
>> >diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> >index 33352e1..41ed5b2 100644
>> >--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> >+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> >@@ -97,7 +97,6 @@ struct pkt_rx_queue {
>> >
>> > struct tx_stats {
>> > uint64_t tx_pkts;
>> >- uint64_t err_pkts;
>> > uint64_t tx_bytes;
>> > };
>> >
>> >@@ -456,7 +455,6 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
>> > stats->imissed += xdp_stats.rx_dropped;
>> >
>> > stats->opackets += stats->q_opackets[i];
>> >- stats->oerrors += txq->stats.err_pkts;
>> > stats->obytes += stats->q_obytes[i];
>> > }
>> >
>> >--
>> >1.8.3.1
>> >
>>
>> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
>Thanks.
>
>--
>David Marchand
next prev parent reply other threads:[~2019-07-26 1:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 9:14 [dpdk-dev] [PATCH 0/8] oerrors stats fixes for virtual pmds David Marchand
2019-07-25 9:14 ` [dpdk-dev] [PATCH 1/8] net/af_packet: remove unused Rx counter David Marchand
2019-07-25 16:06 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-dev] [PATCH 2/8] net/af_xdp: remove unused Tx counter David Marchand
2019-07-25 15:49 ` Ye Xiaolong
2019-07-25 19:04 ` David Marchand
2019-07-26 1:33 ` Ye Xiaolong [this message]
2019-07-25 9:14 ` [dpdk-dev] [PATCH 3/8] net/null: remove unused Tx error counter David Marchand
2019-07-25 16:06 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-dev] [PATCH 4/8] net/virtio: " David Marchand
2019-07-26 2:39 ` Tiwei Bie
2019-07-25 9:14 ` [dpdk-dev] [PATCH 5/8] net/kni: do not count unsent packets as errors David Marchand
2019-07-25 16:12 ` Ferruh Yigit
2019-07-25 19:07 ` David Marchand
2019-07-26 7:24 ` David Marchand
2019-07-26 10:17 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-dev] [PATCH 6/8] net/memif: " David Marchand
2019-07-25 16:18 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-dev] [PATCH 7/8] net/ring: " David Marchand
2019-07-25 16:19 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-dev] [PATCH 8/8] net/vhost: " David Marchand
2019-07-26 2:44 ` Tiwei Bie
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 0/9] oerrors stats fixes for virtual pmds David Marchand
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 1/9] net/af_packet: remove unused Rx counter David Marchand
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 2/9] net/af_xdp: remove unused Tx counter David Marchand
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 3/9] net/null: remove unused Tx error counter David Marchand
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 4/9] net/virtio: " David Marchand
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 5/9] net/kni: remove unused Rx "error" counter David Marchand
2019-07-26 13:23 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 6/9] net/kni: do not count unsent packets as errors David Marchand
2019-07-26 13:23 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 7/9] net/memif: " David Marchand
2019-07-26 13:24 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 8/9] net/ring: " David Marchand
2019-07-26 13:24 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-dev] [PATCH v2 9/9] net/vhost: " David Marchand
2019-07-26 13:28 ` [dpdk-dev] [PATCH v2 0/9] oerrors stats fixes for virtual pmds Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726013323.GA25993@intel.com \
--to=xiaolong.ye@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).