From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AD0FA046B for ; Fri, 26 Jul 2019 03:33:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59D361C394; Fri, 26 Jul 2019 03:33:29 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E354A1C387 for ; Fri, 26 Jul 2019 03:33:27 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 18:33:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,308,1559545200"; d="scan'208";a="170481685" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.185]) by fmsmga008.fm.intel.com with ESMTP; 25 Jul 2019 18:33:26 -0700 Date: Fri, 26 Jul 2019 09:33:23 +0800 From: Ye Xiaolong To: David Marchand Cc: dev , "Yigit, Ferruh" , Qi Zhang Message-ID: <20190726013323.GA25993@intel.com> References: <1564046068-21905-1-git-send-email-david.marchand@redhat.com> <1564046068-21905-3-git-send-email-david.marchand@redhat.com> <20190725154915.GA29561@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 2/8] net/af_xdp: remove unused Tx counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/25, David Marchand wrote: >On Thu, Jul 25, 2019 at 5:49 PM Ye Xiaolong wrote: >> >> On 07/25, David Marchand wrote: >> >This Tx counter is now unused. >> > >> >Fixes: 10edf857fde4 ("net/af_xdp: make reserve/submit peek/release consistent") >> >> err_pkts seems not introduced by this commit? > >This commit removed the only place where it was used. > Got it, make sense. Thanks, Xiaolong >> >> > >> >Signed-off-by: David Marchand >> >--- >> > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 -- >> > 1 file changed, 2 deletions(-) >> > >> >diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c >> >index 33352e1..41ed5b2 100644 >> >--- a/drivers/net/af_xdp/rte_eth_af_xdp.c >> >+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c >> >@@ -97,7 +97,6 @@ struct pkt_rx_queue { >> > >> > struct tx_stats { >> > uint64_t tx_pkts; >> >- uint64_t err_pkts; >> > uint64_t tx_bytes; >> > }; >> > >> >@@ -456,7 +455,6 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) >> > stats->imissed += xdp_stats.rx_dropped; >> > >> > stats->opackets += stats->q_opackets[i]; >> >- stats->oerrors += txq->stats.err_pkts; >> > stats->obytes += stats->q_obytes[i]; >> > } >> > >> >-- >> >1.8.3.1 >> > >> >> Reviewed-by: Xiaolong Ye > >Thanks. > >-- >David Marchand