From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA142A046B for ; Fri, 26 Jul 2019 22:50:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 630861C4DB; Fri, 26 Jul 2019 22:50:55 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 0DC3D1C4A3 for ; Fri, 26 Jul 2019 22:50:53 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id w10so25311511pgj.7 for ; Fri, 26 Jul 2019 13:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=43mjaO4QcOIU/qqM3N3cN+AzSg65OO7pVrSSdLwsWys=; b=qrxgiVra5MIH/4ruhtCeRjo7vM+eyXGoheigq9uCY+jg2Bmci3wv/JMV2TDe0fYrXD K0tb20yOGZVA5OHKEbEro2bjbXc/08W/uB9YxcDB1ba+4GUS/nwBS5sgMxRn5+7CMImO BpthOJrb8vLiJWo+yngComLt7FXCnq6gbpjg6bRVNqGOhtAdMJLTiFX8huwB3p0gnxtM 7kXhLOoQMyrmNI7zqkghRIjyKwuOuzgE4AdkqNbw0LPRD1rg8Xxx7Sk2ENA/F9/WW0hL t2IxvF0xHjeRUZIThBi/A2eY/nbcf4y8H57Wm1dV4U/LoVVdSILePibCQ4MEjwamuJpH Adlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=43mjaO4QcOIU/qqM3N3cN+AzSg65OO7pVrSSdLwsWys=; b=bFDVzozxHQgf1SKG+uSuTIDl7HgyQBbaqyOWzaDrJde33d/tpQIqfjnwDjRJ8BUyw1 BPN1muUojk9EK2/tF0KtMenEicvQabNrRwbyf/G3HLdLNQp3B3kzOkNTZwXh4eBrfbeN 8sjTFqZ6Jpst8yu8z/vo87QVHdvQv6B57pQP58/UFNnWVCJAO2YupPKRfRBo3l2GPyWV i6tOYtDHwDcgxZHDewCs6W/Qb5WD/RqeOs4Y/Z6Eww6nuHdhnTr/1Gl7eYiPXI9v5IAB LtAOepOl7LQa79Rqp12hM43Hqw+G31Rp504X+dKm71fk+Catrmdw7bvoMTxOUbrEuehe iELw== X-Gm-Message-State: APjAAAVCoenwWaQcpxvdoUa7lf2ixAzFdrG0TXLdBVYLtYx1WfXpwrq6 JqxANGw0q+/MrcsvbBAB2S0= X-Google-Smtp-Source: APXvYqxP1PaQ6eEosbZlaKFRpjlTlJpX05Q28OMZkyDnk+lVcG8rXHykF7ONDNI4xNJ5QfrA+5Iq8w== X-Received: by 2002:a63:7b4d:: with SMTP id k13mr91167483pgn.182.1564174253102; Fri, 26 Jul 2019 13:50:53 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y14sm3260754pge.7.2019.07.26.13.50.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 13:50:53 -0700 (PDT) Date: Fri, 26 Jul 2019 13:50:44 -0700 From: Stephen Hemminger To: "Hyong Youb Kim (hyonkim)" Cc: "John Daley (johndale)" , Ferruh Yigit , "dev@dpdk.org" Message-ID: <20190726135044.287956ae@hermes.lan> In-Reply-To: References: <20190725024619.26040-1-johndale@cisco.com> <4fe558a6-b2b5-0401-ac0b-6ca45f0389f9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 26 Jul 2019 04:21:23 +0000 "Hyong Youb Kim (hyonkim)" wrote: > > -----Original Message----- > > From: John Daley (johndale) > > Sent: Friday, July 26, 2019 5:26 AM > > To: Ferruh Yigit > > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > > Subject: RE: [PATCH] net/enic: retain previous message logging > > > > Ok, lets NAK this patch. See comment inline. > > Thanks, > > John > > > [...] > > > On 7/25/2019 3:46 AM, John Daley wrote: > > > > Prior to fix, RTE_LOGTYPE_INFO messages would display in testpmd by > > > > default. After the fix, using dynamic logging, only NOTICE level and > > > > higher were displayed by default and INFO level were not. Change the > > > > messages to NOTICE level so they continue to display. > > > > > > > > DTS uses testpmd and parses messages and some tests failed because > > > > messages were no longer displayed. Other apps may also depend on the > > > > messages. > > > > > > If you need messages for the test framework, why not just increase the log > > > level for enic PMD via application parameter [1], or as command to > > > testpmd[2]? > > > Since it is dynamic debug now, you don't need to change the default, can > > > change the level on demand. > > > > I have no problem modifying our test scripts. The bigger concern was about > > any other scripts out there that might break because the default enic PMD > > messages changed. I suppose chances are slim and any such scripts can easily > > be modified to set the log level to info. > > > > Hi John, Ferruh, > > Can you guys reconsider? John's commit message makes it sound like he > is modifying PMD to avoid modifying test scripts. That is not the > issue at all. The real problem is that his previous commit causes > a customer visible change, which can lead to a lot of headache for both > us (doing tech support) and customers (wondering what's changed). > > Prior to commit bbd8ecc05434 ("net/enic: remove PMD log type references"): > > enic prints vNIC config related messages (rq/cq/wq info and such) via > dev_info(). And, dev_info() uses LOGTYPE_PMD and the INFO level. > LOGTYPE_PMD defaults to the INFO level, so these messages appear by > default. Customers and tech support use them for debugging and so on. > > After the commit: > > dev_info() is now enic_pmd_logtype, which defaults to NOTICE. The > macro is still using the INFO level. So, config messages are > suppressed by default. This was never the intention. The current patch > tries to fix that by elevating dev_info to dev_notice, because we do > want these messages to appear by default. Should have done it as part > of the previous commit, but we missed it. > > Down the line, we will have to guide our customers to exploit dynamic log > levels, but not this way (i.e. suddenly hiding messages that they used > to see/rely on). > > Thanks a lot. > -Hyong > Drivers should be silent unless they see a problem. We don't want every driver outputting messages by default. For your current issue, why not just register the default log level as info?