From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40643A0487 for ; Mon, 29 Jul 2019 11:22:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 803161BF07; Mon, 29 Jul 2019 11:22:45 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id A59401BF03 for ; Mon, 29 Jul 2019 11:22:43 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id p74so53103634wme.4 for ; Mon, 29 Jul 2019 02:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HwdZDeKXMCbgY+dnoxnBRhresmC5m9Y90EmemxYJwyU=; b=QuhGk5CxeJXVlK3GjGbQ0z3HTHbwFdH6ylEFd/hFY2JAX7e22KD+ObnDd280YLVg4a s6gFFlgzkovfsSVmLpXORfdWCkp1vMppLzFpPWaT3lPkfphCve6eRGfB6EEjp/eJNt41 MsyO23YAgNBFK/x7C3QstPN43Tultmwk62rDGrq0YXbn2FlRH+xrr+kiCuvnFohd5Rvm 8xmvaogBVUCpDnZKq8voXR1jCaKae+HbpONgPJrkpctxNK5N3CT7zcGkzTHsMO6KiUWY BgYRJnnliO9uVzlN4lnPQRZfra/Wm3NuT0BLJmyJiUF0tH/RggQ+9PYpiUs0ei573NIG Sm0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HwdZDeKXMCbgY+dnoxnBRhresmC5m9Y90EmemxYJwyU=; b=FV0QcIm/XpnV5PFOqYLQ0ALgD8KBYR5I6EGyyrwh8rHrBoOE64kr7zyhi/K2hERiNs An3Fu6Xt+R51f8qJUdRqrd45LXH1z6WeF1ago3XntlN4bDUXTfUooWzm/HFX8VUfDIpg 6fdjBWbthFvDyaPvlBFayqFYMAOvpC+Q7NgBdw35KbrLGwjv7SbnmuE2TP+qygYgHq+c GDRQsuAUjj/xu2U6ezoCT7gfYlTQAXaXVJ34avz/MrxJXHhDwuVXeLW51yJzl9oU0Puo ggNw04WtiUqCBwtWsMUGpJD81VJTb+9mRdLosFe4TUKHAGxXjzMTVhjLN5bKuqLPVcZd ASKw== X-Gm-Message-State: APjAAAUSvcxkXNp6xPe4/R1UaqQsb46GP61goQUTqp3uc07mkAkzD/Nx 20QLDgUOOsw8O1Vij0zidhB9cw== X-Google-Smtp-Source: APXvYqw16KwjAVZOO1ctSkZMm+hrR4XTWeDwrYk6bj5UZhuz9DRgPox87r0v9LiXIi/iH8kmou8vjQ== X-Received: by 2002:a7b:c04f:: with SMTP id u15mr9897371wmc.106.1564392163210; Mon, 29 Jul 2019 02:22:43 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t63sm52938710wmt.6.2019.07.29.02.22.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jul 2019 02:22:42 -0700 (PDT) Date: Mon, 29 Jul 2019 11:22:33 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: David Marchand Cc: Thomas Monjalon , "Morrissey, Sean" , "Laatz, Kevin" , "dev@dpdk.org" Message-ID: <20190729092233.26wx7la5nsc3u4fm@bidouze.vm.6wind.com> References: <20190724152059.17859-1-sean.morrissey@intel.com> <5173895.pTg1DfyaZ9@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 29, 2019 at 10:40:59AM +0200, David Marchand wrote: > On Sun, Jul 28, 2019 at 9:55 PM Thomas Monjalon wrote: > > 25/07/2019 10:42, David Marchand: > > > > > > 24/07/2019 17:20, Sean Morrissey: > > > > On further investigation, the full fix involves > > > > a change in the EAL command line parameter handling, > > > > which is probably too risky for RC3. > > > > No way you change the command line parsing, > > except the rte_option which was created for telemetry. > > The history of this "simple" feature is already full > > of hesitations which made me hesitate to merge. > > Please, don't force me to dig in the code, otherwise > > I will be tempted to do a big "clean-up". > > > > > > This revert will allow telemetry to function again, > > > > but with the erroneous message still in place. > > > > We will aim to fix in the next release. > > > > > > Might be good to look and revisit the rte_option api. > > > > The patch on eal did not make any sense. > I am for reverting it too. > Hi all, quick look at it: 719 /* 720 * getopt didn't recognise the option, lets parse the 721 * registered options to see if the flag is valid 722 */ 723 if (opt == '?') { 724 ret = rte_option_parse(argv[optind-1]); 725 if (ret == 0) 726 continue; 727 728 eal_usage(prgname); 729 ret = -1; 730 goto out; 731 } If the --telemetry option is added to the EAL command line, then this branch will not happen, which explains why the socket was not opened on the lib side. > About the real fix, I'd like to first see a description of the actual problem. > Thanks. > > > -- > David Marchand Agreed, to add to this: was the build shared? It seems Stephen encountered errors with RTE_INIT of DPDK libs not being executed in shared builds, which could explain why everything would seem fine, but the rte_option would not be registered, making the parsing error appear. -- Gaëtan Rivet 6WIND