DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"
@ 2019-07-24 15:20 Sean Morrissey
  2019-07-24 15:31 ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Sean Morrissey @ 2019-07-24 15:20 UTC (permalink / raw)
  To: dev; +Cc: thomas, Sean Morrissey

This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba.

Reverting this patch as it currently breaks the initialization of
telemetry, more investigation is ongoing to fix the issue for the
printed error message for unrecognized argument.

Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
---
v2:
  Adding sign off
---
 lib/librte_eal/common/eal_common_options.c | 3 ---
 lib/librte_eal/common/eal_options.h        | 4 ----
 2 files changed, 7 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 24e36cf23..512d5088e 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -81,9 +81,6 @@ eal_long_options[] = {
 	{OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
 	{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
 	{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
-#ifdef RTE_LIBRTE_TELEMETRY
-	{OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
-#endif
 	{0,                     0, NULL, 0                        }
 };
 
diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
index e4c8e25c2..9855429e5 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -69,10 +69,6 @@ enum {
 	OPT_IOVA_MODE_NUM,
 #define OPT_MATCH_ALLOCATIONS  "match-allocations"
 	OPT_MATCH_ALLOCATIONS_NUM,
-#ifdef RTE_LIBRTE_TELEMETRY
-	#define OPT_TELEMETRY          "telemetry"
-		OPT_TELEMETRY_NUM,
-#endif
 	OPT_LONG_MAX_NUM
 };
 
-- 
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-07-29 20:06 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 15:20 [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry" Sean Morrissey
2019-07-24 15:31 ` Thomas Monjalon
2019-07-24 16:28   ` Morrissey, Sean
2019-07-24 21:34     ` Thomas Monjalon
2019-07-25  8:38       ` Morrissey, Sean
2019-07-25  8:42         ` David Marchand
2019-07-28 19:55           ` Thomas Monjalon
2019-07-29  8:40             ` David Marchand
2019-07-29  9:22               ` Gaëtan Rivet
2019-07-29 20:06               ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).