From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37BEAA0487 for ; Tue, 30 Jul 2019 08:57:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A1C221BF10; Tue, 30 Jul 2019 08:57:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id A83511BECE for ; Tue, 30 Jul 2019 08:57:27 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6U6unvr027956; Mon, 29 Jul 2019 23:57:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=pfpt0818; bh=zh3rG3dqzVBRadFX9aESqPjaxBfnAHVeKJ7SPrGc/uI=; b=ysKvjvnA7CWxOhKk77bBPxMFtdKIqy9C+PWc3Pk7DF3SVGCDKBnyneWb8XQHTCtGOerv OsIH1P/L1MlUy1Z9UV0FiNFJgIY9uOyXUI2zazgtjS3FRNXO4Dw+tLzsbZII9v8oj9jU 8o/Ri5hyPCg+6EGecIVwP7lmU3YqC9Se11tAVwK13GYlUkzQGwGt0r0UOrxVC+mTSxrc e6vRAuSl2ehho4xHtsMoOv91U3OUNH3DtJyT+/fsQs8LjwBSZRwXvoS+jcsk681OZ/Kv 5V0TwkjHLQgw9CWJh5eXsDcrzw7DwNno823Ld/09udiLAne5mJ/2mC2kNgpFuHuLj5WE tA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2u0p4m2d41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 29 Jul 2019 23:57:26 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 29 Jul 2019 23:57:24 -0700 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.57) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 29 Jul 2019 23:57:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mgsc2kXMJYetGZh9JxRnFGJP5+HKLtWundQrvu7qJsJuI3MNKjr+bvBU8moA3cNAEb3DS5nCAb/n4Iza5o/Jno3v3kYf3fvhptIYOR+BPYWYkwzDmHUgzxWTwyxQ1j32UEQXPkEhH8WcF7HkwXjf7+exvH8DHyi48c8XByfbRuT+m/0352ZzSNY/aV2fJNwGjwsedKIQQNxkRtwJhe59VA2LUD0/mhW6482L673cXOQroXpL6nZ59W8adwcPMHdjnuDOdFVu7+JE2L58qIB0JtF1/DliMnpP6XTLLE58RO9S1nZFKVt3S2ZXxebsXD1c17QgOmuqPoU7yAWOvF9etA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zh3rG3dqzVBRadFX9aESqPjaxBfnAHVeKJ7SPrGc/uI=; b=HfksBz6CRLi3ogYDyHVod39Xtw7sneuHc6Cl1UoHj1ClX5rBQg3WJ/XrGb6KT/qFeNRlyCRQirxQUD9ob3dIwQuXXpklmHmjvfOhAgbT0oBWZR060rUo+3cLFouLdk23iihVVGzG0aaV3sU9960ebTRBX0FO057aeuQwCKWaZ3slrtuHz/3r6S8nqnKJsb2p5kpSxtwZ+Fspo/I0CbguuYMkSQMYugEi7a9z+nMUeHdqv3uIAVZj2k8xP0YxMEyp97IU5kOlaskVyQR44TwwObKH9yDcNAqx2B3vx8dmVtknnaDBDWV95DiTZU0ilfTIjXG6VyE8DgbiOkrTBADK4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zh3rG3dqzVBRadFX9aESqPjaxBfnAHVeKJ7SPrGc/uI=; b=pB/fMZCikwuuTHuAUikLalEDgcKs4KF1Ql39rA/FXPANmqno/RWzY0NuChEY28SAbuoaY13doCcW+PEFIgyA9gqFzwiBRYlq7q+iwGbyJ0Jwk87qZng63D8iYx0nawFepcEqcgwR/ydRPEOIJD9QyeG4lF3IAHODjXK39+0uj/E= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.21.149) by MN2PR18MB3117.namprd18.prod.outlook.com (10.255.86.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.12; Tue, 30 Jul 2019 06:57:23 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18%7]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 06:57:23 +0000 From: Harman Kalra To: Thomas Monjalon CC: "dev@dpdk.org" , John McNamara , Pablo de Lara , Bruce Richardson , Harry van Haaren , Xiaoyun Li , "barbette@kth.se" , Yongseok Koh , "viacheslavo@mellanox.com" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix HW timestamp enable Thread-Index: AQHVQwDjmhj5fSrF40Cc6qCNGgyhrqbiMTqAgACQwQA= Date: Tue, 30 Jul 2019 06:57:22 +0000 Message-ID: <20190730065702.GA23822@outlook.office365.com> References: <1564069902-3500-1-git-send-email-hkalra@marvell.com> <2174860.Ph4OkxdjrP@xps> In-Reply-To: <2174860.Ph4OkxdjrP@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR0101CA0069.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::31) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:3e::21) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34e61a40-fd2d-4e3b-41ec-08d714bb2c12 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB3117; x-ms-traffictypediagnostic: MN2PR18MB3117: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(376002)(396003)(346002)(136003)(199004)(189003)(4326008)(81166006)(8676002)(316002)(54906003)(81156014)(14454004)(52116002)(53936002)(256004)(476003)(86362001)(6916009)(68736007)(8936002)(478600001)(305945005)(7736002)(25786009)(2906002)(55236004)(386003)(6246003)(7416002)(6486002)(6506007)(76176011)(6436002)(102836004)(66066001)(6512007)(9686003)(486006)(71200400001)(71190400001)(66946007)(11346002)(186003)(446003)(26005)(99286004)(3846002)(229853002)(66446008)(33656002)(66556008)(64756008)(6116002)(1076003)(5660300002)(66476007); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3117; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: abubur5w9mqtlzy/O90gFsJW4TuCwMlb8cZn4lR3lM4sdmoLiSx6qH9u76+aRmxlAW83CSpPIgjnoKt09I69WzJEeYX+JpK0YoURw97n/4PH4VOhXZc9WmHmt8dwKOzRu20YeYcuFl++ijHT6Rk6GoM7TyGO0Z112nM1Fq/pmpoSeK7zp99Q0rHMrbLivxY4ZvWJsQ3oTSS/bh8zAR2Kqm9TnIkDwK8ZGxmps7mrvY+ZpVVXKL0PXwxp3Z0W7PUHikyD6zGzlR4XsA8+ahCIsSngO7LnXq2HI3Kx+n3+Iw6WLTJh4ifNKO86AhTYntbGQiYP3+uaDWcMbQVENxMrP2BdmPf6aunvfGs59AcxoLozOGcaHuV9E45CoyMOSDz/5oIqbOEl0AKGosCpZB1Blfu8a3zXpFLpo4ExRplJpYI= Content-Type: text/plain; charset="us-ascii" Content-ID: <9661BBA747C78B478B55CA2035344575@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 34e61a40-fd2d-4e3b-41ec-08d714bb2c12 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 06:57:22.9796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hkalra@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3117 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-30_03:2019-07-29,2019-07-30 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] examples/rxtx_callbacks: fix HW timestamp enable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 30, 2019 at 12:18:59AM +0200, Thomas Monjalon wrote: > External Email >=20 > ---------------------------------------------------------------------- > 25/07/2019 17:51, Harman Kalra: > > Offloafing Rx timestamp is a device capability than queue capability. >=20 > Why is it a device capability and not a queue capability? 1. Since all PMDs doesn't implements per queue offload capabilities but supports RX timestamping and also since rx_offload_capa includes all rx_queue_offload_capa's. So we moved the DEV_RX_OFFLOAD_TIMESTAMP configuration setting to device from queue, as its a test application and should work with all PMDs. 2. Or we can have a test in this application, i.e. if PMD has rx_queue_offload_capa implemented go with per queue configuration else make it a device configuration. If OK with this first approach, we will send V2 with reworded commit messag= e=20 explaining the reason as above. >=20 > > Hence the logic to enable HW timestamp via DEV_RX_OFFLOAD_TIMESTAMP > > flag should be before device configuration. > >=20 > > Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") > > Cc: barbette@kth.se > >=20 > > Signed-off-by: Harman Kalra >=20 >=20 >=20