[dpdk-dev] [PATCH 0/5] blank lines at EOF fixes

[dpdk-dev] [PATCH 0/5] blank lines at EOF fixes

[Stephen Hemminger]

Using a simple shell script which cleans up trailing whitespace
found several places with extra lines at end of file.

More in base drivers but they are known to be problematic.

Stephen Hemminger (5):
  examples: remove extra blank lines at eof
  test: remove blank lines at eof
  pmdinfogen: remove blank line at eof
  net/ipn3ke: cleanup blank line at eof
  net/mlx5: remove blank lines at eof

 app/test/test_cryptodev_asym_util.h   | 4 ----
 app/test/test_table_combined.c        | 1 -
 app/test/test_table_tables.c          | 3 +--
 buildtools/pmdinfogen/pmdinfogen.h    | 1 -
 drivers/net/ipn3ke/ipn3ke_flow.c      | 1 -
 drivers/net/ipn3ke/ipn3ke_tm.c        | 1 -
 drivers/net/mlx5/mlx5_rxtx.c          | 2 --
 examples/flow_filtering/flow_blocks.c | 1 -
 examples/l3fwd-power/perf_core.c      | 1 -
 examples/vhost_scsi/vhost_scsi.c      | 1 -
 10 files changed, 1 insertion(+), 15 deletions(-)

-- 
2.20.1

[dpdk-dev] [PATCH 1/5] examples: remove extra blank lines at eof

[Stephen Hemminger]

There should not be blank lines at end of files.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 examples/flow_filtering/flow_blocks.c | 1 -
 examples/l3fwd-power/perf_core.c      | 1 -
 examples/vhost_scsi/vhost_scsi.c      | 1 -
 3 files changed, 3 deletions(-)

diff --git a/examples/flow_filtering/flow_blocks.c b/examples/flow_filtering/flow_blocks.c
index 1edf6f9c625c..575d79281074 100644
--- a/examples/flow_filtering/flow_blocks.c
+++ b/examples/flow_filtering/flow_blocks.c
@@ -98,4 +98,3 @@ generate_ipv4_flow(uint16_t port_id, uint16_t rx_q,
 
 	return flow;
 }
-
diff --git a/examples/l3fwd-power/perf_core.c b/examples/l3fwd-power/perf_core.c
index 83948ea21b2d..0a294dfcc826 100644
--- a/examples/l3fwd-power/perf_core.c
+++ b/examples/l3fwd-power/perf_core.c
@@ -227,4 +227,3 @@ parse_perf_core_list(const char *corelist)
 
 	return 0;
 }
-
diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c
index 513af0cca4bc..a92630c77c40 100644
--- a/examples/vhost_scsi/vhost_scsi.c
+++ b/examples/vhost_scsi/vhost_scsi.c
@@ -485,4 +485,3 @@ int main(int argc, char *argv[])
 
 	return 0;
 }
-
-- 
2.20.1

[dpdk-dev] [PATCH 2/5] test: remove blank lines at eof

[Stephen Hemminger]

Several tests have extraneous blank lines at end of file.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_cryptodev_asym_util.h | 4 ----
 app/test/test_table_combined.c      | 1 -
 app/test/test_table_tables.c        | 3 +--
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/app/test/test_cryptodev_asym_util.h b/app/test/test_cryptodev_asym_util.h
index b3d9fb4688da..f2a8e6ce15ba 100644
--- a/app/test/test_cryptodev_asym_util.h
+++ b/app/test/test_cryptodev_asym_util.h
@@ -36,7 +36,3 @@ static inline int verify_modexp(uint8_t *mod_exp,
 }
 
 #endif /* TEST_CRYPTODEV_ASYM_TEST_UTIL_H__ */
-
-
-
-
diff --git a/app/test/test_table_combined.c b/app/test/test_table_combined.c
index 73ad0155d677..f72b634bff70 100644
--- a/app/test/test_table_combined.c
+++ b/app/test/test_table_combined.c
@@ -840,4 +840,3 @@ test_table_hash_cuckoo_combined(void)
 
 	return 0;
 }
-
diff --git a/app/test/test_table_tables.c b/app/test/test_table_tables.c
index 21c4086c2321..1aa269f95d27 100644
--- a/app/test/test_table_tables.c
+++ b/app/test/test_table_tables.c
@@ -911,7 +911,7 @@ test_table_hash_cuckoo(void)
 		.n_keys = 1 << 16,
 		.n_buckets = 1 << 16,
 		.f_hash = pipeline_test_hash_cuckoo,
-		.seed = 0, 
+		.seed = 0,
 	};
 
 	table = rte_table_hash_cuckoo_ops.f_create(NULL, 0, entry_size);
@@ -1051,4 +1051,3 @@ test_table_hash_cuckoo(void)
 
 	return 0;
 }
-
-- 
2.20.1

[dpdk-dev] [PATCH 3/5] pmdinfogen: remove blank line at eof

[Stephen Hemminger]

No need for blank line at end of file.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 buildtools/pmdinfogen/pmdinfogen.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h
index 27bab30e5eb0..c8a9e2136add 100644
--- a/buildtools/pmdinfogen/pmdinfogen.h
+++ b/buildtools/pmdinfogen/pmdinfogen.h
@@ -122,4 +122,3 @@ struct elf_info {
 
 	struct pmd_driver *drivers;
 };
-
-- 
2.20.1

[dpdk-dev] [PATCH 4/5] net/ipn3ke: cleanup blank line at eof

[Stephen Hemminger]

Leftover from editor? Remove blank lines at end of file.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/ipn3ke/ipn3ke_flow.c | 1 -
 drivers/net/ipn3ke/ipn3ke_tm.c   | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/net/ipn3ke/ipn3ke_flow.c b/drivers/net/ipn3ke/ipn3ke_flow.c
index f3aec979371d..9fc3c8bf763f 100644
--- a/drivers/net/ipn3ke/ipn3ke_flow.c
+++ b/drivers/net/ipn3ke/ipn3ke_flow.c
@@ -1372,4 +1372,3 @@ const struct rte_flow_ops ipn3ke_flow_ops = {
 	.destroy = ipn3ke_flow_destroy,
 	.flush = ipn3ke_flow_flush,
 };
-
diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c
index 10828fce006a..adf02c15705d 100644
--- a/drivers/net/ipn3ke/ipn3ke_tm.c
+++ b/drivers/net/ipn3ke/ipn3ke_tm.c
@@ -2060,4 +2060,3 @@ ipn3ke_tm_ops_get(struct rte_eth_dev *ethdev,
 
 	return 0;
 }
-
-- 
2.20.1

[dpdk-dev] [PATCH 5/5] net/mlx5: remove blank lines at eof

[Stephen Hemminger]

Whitespace fix.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/mlx5/mlx5_rxtx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index a4fc388d2293..8acd8cd2a4a9 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -5161,5 +5161,3 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)
 		DRV_LOG(DEBUG, "\tEMPW  (Enhanced MPW)");
 	return txoff_func[m].func;
 }
-
-
-- 
2.20.1

Re: [dpdk-dev] [PATCH 0/5] blank lines at EOF fixes

[Bruce Richardson]

On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote:
> Using a simple shell script which cleans up trailing whitespace
> found several places with extra lines at end of file.
> 
> More in base drivers but they are known to be problematic.
> 
> Stephen Hemminger (5):
>   examples: remove extra blank lines at eof
>   test: remove blank lines at eof
>   pmdinfogen: remove blank line at eof
>   net/ipn3ke: cleanup blank line at eof
>   net/mlx5: remove blank lines at eof
> 
>  app/test/test_cryptodev_asym_util.h   | 4 ----
>  app/test/test_table_combined.c        | 1 -
>  app/test/test_table_tables.c          | 3 +--
>  buildtools/pmdinfogen/pmdinfogen.h    | 1 -
>  drivers/net/ipn3ke/ipn3ke_flow.c      | 1 -
>  drivers/net/ipn3ke/ipn3ke_tm.c        | 1 -
>  drivers/net/mlx5/mlx5_rxtx.c          | 2 --
>  examples/flow_filtering/flow_blocks.c | 1 -
>  examples/l3fwd-power/perf_core.c      | 1 -
>  examples/vhost_scsi/vhost_scsi.c      | 1 -
>  10 files changed, 1 insertion(+), 15 deletions(-)
> 
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

I really wonder if removing blank lines at EOF would really be a problem
for base drivers? Seems like it should not be a major issue, but perhaps
maintainers best comment first.

Re: [dpdk-dev] [PATCH 5/5] net/mlx5: remove blank lines at eof

[Slava Ovsiienko]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
> Sent: Wednesday, July 31, 2019 17:58
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH 5/5] net/mlx5: remove blank lines at eof
> 
> Whitespace fix.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Thank you, 
Slava

> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index a4fc388d2293..8acd8cd2a4a9 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -5161,5 +5161,3 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)
>  		DRV_LOG(DEBUG, "\tEMPW  (Enhanced MPW)");
>  	return txoff_func[m].func;
>  }
> -
> -
> --
> 2.20.1

Re: [dpdk-dev] [PATCH 0/5] blank lines at EOF fixes

[Thomas Monjalon]

31/07/2019 17:38, Bruce Richardson:
> On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote:
> > Using a simple shell script which cleans up trailing whitespace
> > found several places with extra lines at end of file.
> > 
> > More in base drivers but they are known to be problematic.
> > 
> > Stephen Hemminger (5):
> >   examples: remove extra blank lines at eof
> >   test: remove blank lines at eof
> >   pmdinfogen: remove blank line at eof
> >   net/ipn3ke: cleanup blank line at eof
> >   net/mlx5: remove blank lines at eof
> > 
> >  app/test/test_cryptodev_asym_util.h   | 4 ----
> >  app/test/test_table_combined.c        | 1 -
> >  app/test/test_table_tables.c          | 3 +--
> >  buildtools/pmdinfogen/pmdinfogen.h    | 1 -
> >  drivers/net/ipn3ke/ipn3ke_flow.c      | 1 -
> >  drivers/net/ipn3ke/ipn3ke_tm.c        | 1 -
> >  drivers/net/mlx5/mlx5_rxtx.c          | 2 --
> >  examples/flow_filtering/flow_blocks.c | 1 -
> >  examples/l3fwd-power/perf_core.c      | 1 -
> >  examples/vhost_scsi/vhost_scsi.c      | 1 -
> >  10 files changed, 1 insertion(+), 15 deletions(-)
> > 
> Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied and squashed, thanks