DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/5] blank lines at EOF fixes
Date: Wed, 31 Jul 2019 16:38:41 +0100	[thread overview]
Message-ID: <20190731153841.GH1705@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190731145742.10776-1-stephen@networkplumber.org>

On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote:
> Using a simple shell script which cleans up trailing whitespace
> found several places with extra lines at end of file.
> 
> More in base drivers but they are known to be problematic.
> 
> Stephen Hemminger (5):
>   examples: remove extra blank lines at eof
>   test: remove blank lines at eof
>   pmdinfogen: remove blank line at eof
>   net/ipn3ke: cleanup blank line at eof
>   net/mlx5: remove blank lines at eof
> 
>  app/test/test_cryptodev_asym_util.h   | 4 ----
>  app/test/test_table_combined.c        | 1 -
>  app/test/test_table_tables.c          | 3 +--
>  buildtools/pmdinfogen/pmdinfogen.h    | 1 -
>  drivers/net/ipn3ke/ipn3ke_flow.c      | 1 -
>  drivers/net/ipn3ke/ipn3ke_tm.c        | 1 -
>  drivers/net/mlx5/mlx5_rxtx.c          | 2 --
>  examples/flow_filtering/flow_blocks.c | 1 -
>  examples/l3fwd-power/perf_core.c      | 1 -
>  examples/vhost_scsi/vhost_scsi.c      | 1 -
>  10 files changed, 1 insertion(+), 15 deletions(-)
> 
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

I really wonder if removing blank lines at EOF would really be a problem
for base drivers? Seems like it should not be a major issue, but perhaps
maintainers best comment first.

  parent reply	other threads:[~2019-07-31 15:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 14:57 Stephen Hemminger
2019-07-31 14:57 ` [dpdk-dev] [PATCH 1/5] examples: remove extra blank lines at eof Stephen Hemminger
2019-07-31 14:57 ` [dpdk-dev] [PATCH 2/5] test: remove " Stephen Hemminger
2019-07-31 14:57 ` [dpdk-dev] [PATCH 3/5] pmdinfogen: remove blank line " Stephen Hemminger
2019-07-31 14:57 ` [dpdk-dev] [PATCH 4/5] net/ipn3ke: cleanup " Stephen Hemminger
2019-07-31 14:57 ` [dpdk-dev] [PATCH 5/5] net/mlx5: remove blank lines " Stephen Hemminger
2019-08-04  9:48   ` Slava Ovsiienko
2019-07-31 15:38 ` Bruce Richardson [this message]
2019-08-05 13:20   ` [dpdk-dev] [PATCH 0/5] blank lines at EOF fixes Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731153841.GH1705@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).