From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A88F7A10DA for ; Thu, 1 Aug 2019 00:55:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B25E1BF62; Thu, 1 Aug 2019 00:55:47 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 36C171BF03 for ; Thu, 1 Aug 2019 00:55:45 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id k189so13757140pgk.13 for ; Wed, 31 Jul 2019 15:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x3MB4i38eWc9vzAW/May5zf1IoaDDaP8mlO/4Rul37o=; b=NuwOL4qeIrS6bMhaebPhqIokf8RxnDH/KEVYVZ7vAcb1AtRIEoMst92eFVBFv9+l4F C4cD8YPMgsKWq+OPxw7oVVEHkjMHVyGIjDzGS9VBcfq/NGbfEZaWyxykAQbENyDVrJtT n1ldzZrurqLmVcpReKwjVZ7hA5aFujsX3Ae9jmBvPsjN1Bj+Fo+snxNaN1fXWZ4qjdl/ 1BAYES4cViR4O9KZIHldJghbPaVKUoF8yqTy+TOm6PzuIWa4rOPPmWktLNnTzG8zDBDi OMLNutlL8tc2aALlsUym1KiktCAY5gWhEiEHDX23SttiFrcSyRZUXzGejEiS2218ORZ0 pPWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x3MB4i38eWc9vzAW/May5zf1IoaDDaP8mlO/4Rul37o=; b=OveTSNF5Sp2b3ai66A5WIYP5nYM8SapiG3UqK5WDjKaZBglP49cMzlrFwMRMOALNMH R4gVaVVh//tJMTFQSSTU41BtFpgtucsD5U44+yKB0EuF3X39ErAVk0wWhnlttCvfeNGE q5huIhTTU6ixCWnz/huIK5PKomwl7tYWIkt1hM1XVcI7tbf6yBzLvwsh6QBKbMipph1S MQyTcgzJnJ0lnyNPKRHDcVUo0BOU+FLYIBYlp64GO2NWFKsdP5vPtFFCvPRAe4EVHWyI NSzxd+cmRD/y+HWz9yqcUd8Vz5BBQmvpR27Tr9Eb/K+64QCPEZeFAVsBbsU0U8z5PjEg yUjw== X-Gm-Message-State: APjAAAUwzXeGXWqHVwua06Sj4JSGkOugOGPVdgVWx4NFyrBPnstes3rr si/vsQn0/sV3e16zCg74YUE= X-Google-Smtp-Source: APXvYqz9UoCbEa/Q65KjydigYsHoaGQkKjmU1uOMzdYP/PVUWlHKDDWL56inxvsc2yTwh7YbKsHf5w== X-Received: by 2002:a17:90a:2ec1:: with SMTP id h1mr5221315pjs.101.1564613744268; Wed, 31 Jul 2019 15:55:44 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p20sm80188943pgi.81.2019.07.31.15.55.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 15:55:44 -0700 (PDT) Date: Wed, 31 Jul 2019 15:55:42 -0700 From: Stephen Hemminger To: David Christensen Cc: viacheslavo@mellanox.com, dev@dpdk.org Message-ID: <20190731155542.44acf845@hermes.lan> In-Reply-To: <1564612871-162495-1-git-send-email-drc@linux.vnet.ibm.com> References: <1564612871-162495-1-git-send-email-drc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 31 Jul 2019 17:41:11 -0500 David Christensen wrote: > The function mlx5_set_min_inline() includes a switch() that checks > various PCI device IDs in order to set the txq_inline_min value. No > value is set when the PCI device ID matches the ConnectX-5 adapters, > resulting in an assert() failure later in the function > mlx5_set_txlimit_params(). > > This error was encountered on an IBM Power 9 system running RHEL 7.6 > w/o Mellanox OFED installed. > > Fixes: 38b4b397a57d ("net/mlx5: add Tx configuration and setup") > Cc: viacheslavo@mellanox.com > > Signed-off-by: David Christensen > --- > drivers/net/mlx5/mlx5.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 3a345c7..0f61dd5 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1341,6 +1341,7 @@ struct mlx5_dev_spawn_data { > * and PFC control may be broken, so disable feature. > */ > config->hw_vlan_insert = 0; > + config->txq_inline_min = MLX5_INLINE_HSIZE_NONE; > break; > default: > config->txq_inline_min = MLX5_INLINE_HSIZE_NONE; This is a case where a simple switch fallthrough would have same effect.