From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B29D6A10DA for ; Thu, 1 Aug 2019 15:22:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3414B1C1E3; Thu, 1 Aug 2019 15:22:06 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id EB3DC1C1DA for ; Thu, 1 Aug 2019 15:22:04 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id n4so73660211wrs.3 for ; Thu, 01 Aug 2019 06:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=EiSz0umoX+xPZKng0TqdTQydU3+gGf+X5z1vBGwf+Ko=; b=VYS3nrpTM19liNAKMbwlghbTh9cNrIVtmScGefNAILgbLK8/hmWVp12Yvz6DIvvUFT zjBjjO/WgACxBhQ68xeKttfL88ofacODJ1r1gZfpWDL0GsR3Mgah6V4uPzcUVhSg89Lh sdcgbNxcc1aLNCi6Ehs009DnqQ+N5N4ZvtCtao4bPG1H2pMrhgSkfheTbf32va8YdeLg VOf2de7YyhzLg/Iqp5mL/e7J1tgebmA8lwkY7T8qcTr4wYqXdTc9Dipl/wA2knraz86z j62kVHyKYlk6UMkpXRy0DaFjO4VmEI88ZFWp9xM7hCMJvpMKTNJoqkEYJUQI90RsM3IU Njeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=EiSz0umoX+xPZKng0TqdTQydU3+gGf+X5z1vBGwf+Ko=; b=Zjot1SkejzRVhG5ZZR9rQtX426Wk/nHDXPg3ZUGD/pfEJM4OMADxjaHqR8xymD5OGY yOD3sFuiNqrG+3qrfWPRjWYan0Dt4Ic2qDZtrt1VubSa4GFyjzE07FdtdFfS6+cyWBb1 qoJygnxOodv6U4gWWKxy55FFbq2UOm+Bd/doeM/a8bTYyi1hcpDlmJrizwZRyF1ojVME vmGEt+k7jq6OpWUuqHLuFlRXa3mr3Tulvog9FJ5BSxxxWtsDZoN0uRO32yj0qN+k6hwE i1qPUCVw1yKFEL7nMzFd980ci1b5bQfLd6YR2zgrclMZDQuqHOCjxxTQPwc8wG6zj5/9 kLxw== X-Gm-Message-State: APjAAAWRjsQY6FfrirCqNYAa0yesPdcuci0RNrSgc10h+GXGf0NG4nn/ 6bcZHr9dcRUaNWtrFUDiL9WOjQ== X-Google-Smtp-Source: APXvYqyz6bXdofwP1QKoC04YPxpx/XEguuyBmSPz9TZgtRpZorYhQpwG+N3GYVS8vl/WmsKucnHrfg== X-Received: by 2002:adf:ea82:: with SMTP id s2mr133359762wrm.91.1564665724634; Thu, 01 Aug 2019 06:22:04 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t24sm67537307wmj.14.2019.08.01.06.22.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Aug 2019 06:22:03 -0700 (PDT) Date: Thu, 1 Aug 2019 15:22:01 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: David Marchand Cc: dev , Aaron Conole , Michael Santana Message-ID: <20190801132201.ty75yrktxep6ei3k@bidouze.vm.6wind.com> References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 01, 2019 at 02:29:21PM +0200, David Marchand wrote: > On Thu, Aug 1, 2019 at 2:28 PM David Marchand wrote: > > > > The memory tests currently check that, for normal mode (not legacy mode), > > there is no memory left behind when exiting. > > > > The problem is that if a ethdev port is allocated when scanning pci > > devices (even if the driver probe fails like when you have a virtio > > management interface attached to the kernel), on exit, dpdk won't free > > the associated memory since ethdev never frees the ethdev memzone. > > > > Workaround this by disabling pci scan. > > Not entirely happy with this patch. > I am open to suggestions :-) > Hello David, Why not cleanup on .fini the ethdev subsystem? There is RTE_UNREGISTER_CLASS() that was added just for that. I think I remember someone (maybe Thomas) not liking it. Why are we keeping the memzones allocated on exit? Debug ? Primary/secondary snafu? I would take this opportunity to troll once again about the default blacklist-mode of the PCI bus, which is still an issue for downstream consumers of DPDK and seems to be kept only to avoid changing the CI infrastructure of upstream contributors. Unfortunately the root-cause might be elsewhere. > > > > Fixes: 651cc78f83b5 ("test: fix hugepage file handling in EAL flags autotest") > > Fixes: 690fd3577e90 ("test/eal: add cases for in-memory and single-file-segments") > > Cc: stable@dpdk.org > > And we might want to drop stable. > > > -- > David Marchand -- Gaëtan Rivet 6WIND