DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Xiao Zhang <xiao.zhang@intel.com>
Cc: dev@dpdk.org, beilei.xing@intel.com, qiming.yang@intel.com,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/5] net/fm10k: fix dereference after null check coverity
Date: Mon, 5 Aug 2019 11:35:09 +0800	[thread overview]
Message-ID: <20190805033509.GD51603@intel.com> (raw)
In-Reply-To: <1564952430-6585-1-git-send-email-xiao.zhang@intel.com>

Hi, Xiao

It's better to have a cover letter for a patch series that contains more than
1 patches, where you can have an overall description of the patchset.

On 08/05, Xiao Zhang wrote:
>The address of receive queue start segment was not updated when found by
>iterated checking, update the address to fix coverity issue.

I suggest to describe more details (dereference after null check) about the
issue other than just say general coverity issue.

>
>Coverity issue: 343416
>Fixes: fe65e1e1 ("fm10k: add vector scatter Rx")
>
>Cc: stable@dpdk.org
>
>Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
>---
> drivers/net/fm10k/fm10k_rxtx_vec.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k_rxtx_vec.c
>index 788e248..9f2c4ac 100644
>--- a/drivers/net/fm10k/fm10k_rxtx_vec.c
>+++ b/drivers/net/fm10k/fm10k_rxtx_vec.c
>@@ -676,6 +676,7 @@ fm10k_recv_scattered_pkts_vec(void *rx_queue,
> 		/* find the first split flag, and only reassemble then*/
> 		while (i < nb_bufs && !split_flags[i])
> 			i++;
>+		rxq->pkt_first_seg = rx_pkts[i];

Minor nit, if i == nb_bufs, above assignment is  meaningless, suggest to move
it after i == nb_bufs check although it doesn't affect the functionality. 
I think it applies for the rest of patches too.

Thanks,
Xiaolong

> 		if (i == nb_bufs)
> 			return nb_bufs;
> 	}
>-- 
>2.7.4
>

  parent reply	other threads:[~2019-08-05  3:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 21:00 Xiao Zhang
2019-08-04 21:00 ` [dpdk-dev] [PATCH 2/5] net/iavf: " Xiao Zhang
2019-08-04 21:00 ` [dpdk-dev] [PATCH 3/5] net/i40e: " Xiao Zhang
2019-08-04 21:00 ` [dpdk-dev] [PATCH 4/5] net/ice: " Xiao Zhang
2019-08-04 21:00 ` [dpdk-dev] [PATCH 5/5] net/ixgbe: " Xiao Zhang
2019-08-05  3:35 ` Ye Xiaolong [this message]
2019-08-05 23:20 ` [dpdk-dev] [v2 0/5] " Xiao Zhang
2019-08-05 15:46   ` Ye Xiaolong
2019-08-06 11:30     ` Zhang, Qi Z
2019-08-06 14:01       ` Ye Xiaolong
2019-08-06 14:13         ` Zhang, Xiao
2019-08-05 23:20   ` [dpdk-dev] [PATCH v2 1/5] net/ixgbe: " Xiao Zhang
2019-08-05 23:20   ` [dpdk-dev] [PATCH v2 2/5] net/ice: " Xiao Zhang
2019-08-05 23:20   ` [dpdk-dev] [PATCH v2 3/5] net/i40e: " Xiao Zhang
2019-08-05 23:20   ` [dpdk-dev] [PATCH v2 4/5] net/iavf: " Xiao Zhang
2019-08-05 23:20   ` [dpdk-dev] [PATCH v2 5/5] net/fm10k: " Xiao Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190805033509.GD51603@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).