From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6661FA0613 for ; Mon, 5 Aug 2019 05:35:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 882C31BE47; Mon, 5 Aug 2019 05:35:38 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 11CD71BE2B; Mon, 5 Aug 2019 05:35:35 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2019 20:35:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,348,1559545200"; d="scan'208";a="373573302" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by fmsmga006.fm.intel.com with ESMTP; 04 Aug 2019 20:35:33 -0700 Date: Mon, 5 Aug 2019 11:35:09 +0800 From: Ye Xiaolong To: Xiao Zhang Cc: dev@dpdk.org, beilei.xing@intel.com, qiming.yang@intel.com, stable@dpdk.org Message-ID: <20190805033509.GD51603@intel.com> References: <1564952430-6585-1-git-send-email-xiao.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1564952430-6585-1-git-send-email-xiao.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 1/5] net/fm10k: fix dereference after null check coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xiao It's better to have a cover letter for a patch series that contains more than 1 patches, where you can have an overall description of the patchset. On 08/05, Xiao Zhang wrote: >The address of receive queue start segment was not updated when found by >iterated checking, update the address to fix coverity issue. I suggest to describe more details (dereference after null check) about the issue other than just say general coverity issue. > >Coverity issue: 343416 >Fixes: fe65e1e1 ("fm10k: add vector scatter Rx") > >Cc: stable@dpdk.org > >Signed-off-by: Xiao Zhang >--- > drivers/net/fm10k/fm10k_rxtx_vec.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k_rxtx_vec.c >index 788e248..9f2c4ac 100644 >--- a/drivers/net/fm10k/fm10k_rxtx_vec.c >+++ b/drivers/net/fm10k/fm10k_rxtx_vec.c >@@ -676,6 +676,7 @@ fm10k_recv_scattered_pkts_vec(void *rx_queue, > /* find the first split flag, and only reassemble then*/ > while (i < nb_bufs && !split_flags[i]) > i++; >+ rxq->pkt_first_seg = rx_pkts[i]; Minor nit, if i == nb_bufs, above assignment is meaningless, suggest to move it after i == nb_bufs check although it doesn't affect the functionality. I think it applies for the rest of patches too. Thanks, Xiaolong > if (i == nb_bufs) > return nb_bufs; > } >-- >2.7.4 >