DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ntb: fix error handling
@ 2019-08-05  5:03 Xiaoyun Li
  2019-08-05  5:57 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
  2019-08-05  6:04 ` [dpdk-dev] [PATCH] " Ye Xiaolong
  0 siblings, 2 replies; 6+ messages in thread
From: Xiaoyun Li @ 2019-08-05  5:03 UTC (permalink / raw)
  To: jingjing.wu; +Cc: dev, Xiaoyun Li, stable

This patch adds return value checking for fseek function to fix
error handling issue found by coverity scan.

Coverity issue: 344996
Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
Cc: stable@dpdk.org

Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
 examples/ntb/ntb_fwd.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c
index c169f01a3..671b13f50 100644
--- a/examples/ntb/ntb_fwd.c
+++ b/examples/ntb/ntb_fwd.c
@@ -107,6 +107,7 @@ cmd_sendfile_parsed(void *parsed_result,
 	uint8_t *buff;
 	uint32_t val;
 	FILE *file;
+	int status;
 
 	if (!rte_rawdevs[dev_id].started) {
 		printf("Device needs to be up first. Try later.\n");
@@ -125,9 +126,17 @@ cmd_sendfile_parsed(void *parsed_result,
 		return;
 	}
 
-	fseek(file, 0, SEEK_END);
+	status = fseek(file, 0, SEEK_END);
+	if (status) {
+		printf("Fail to get file size.\n");
+		return;
+	}
 	size = ftell(file);
-	fseek(file, 0, SEEK_SET);
+	status = fseek(file, 0, SEEK_SET);
+	if (status) {
+		printf("Fail to get file size.\n");
+		return;
+	}
 
 	/**
 	 * No FIFO now. Only test memory. Limit sending file
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-08-06  8:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05  5:03 [dpdk-dev] [PATCH] examples/ntb: fix error handling Xiaoyun Li
2019-08-05  5:57 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2019-08-06  7:45   ` Ye Xiaolong
2019-08-06  8:33     ` Thomas Monjalon
2019-08-05  6:04 ` [dpdk-dev] [PATCH] " Ye Xiaolong
2019-08-05  6:19   ` Li, Xiaoyun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).