From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 698D1A00E6 for ; Tue, 6 Aug 2019 17:45:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 522F51B502; Tue, 6 Aug 2019 17:45:37 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id D4AE81B464 for ; Tue, 6 Aug 2019 17:45:35 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id b3so38062444plr.4 for ; Tue, 06 Aug 2019 08:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/sVUQjagCpHSOl273Thr+pgW3EQlxIBrBD5/eWCn27I=; b=kpj4ZcfS1HVCaaLvmtPZqcPpjXnNz1BSVXuK35DrCFl3jrG8TrUNJ85LMUNIiJKJHU vb2dKQGctDuLp6ELzZal3cwLc2U0UYwmJBcpz7IBEcsvRnunnxPsmPSgORbB8UySl8p1 m4B2pkz9dYGJie0HNHvClKdlHyfbWfUtWWkASE5Ib0bvCArn4mXMdTf/CRYehWbGjSjw m5wZ1xOFltcovT+PNduMM97KS7l0P99Rx0yOt79ctUdswrs4SQEE64rwmagRpd8jI0z+ 4P8s5xPtDGOh0mRTL2h18cT7q+kE2oyMOYi1ccnrHmeaVJf2wZaynCHexjPnxXq2P/Ot /n1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/sVUQjagCpHSOl273Thr+pgW3EQlxIBrBD5/eWCn27I=; b=Sp9V5Wa4wayCJOBR/RnNZ84oK7KuP/TfTg9/gtx+25OnRnKoqx6iUY+8NaEIlsjm58 GBpmwL8RyaUFCavCAX4fPRH+gktxiDZKp80LXcxxStobF37zT1X2iS4z0NWC8b9nav7N ujQDuqqL41DgdDd4Uf5VosqEFiWZOUaxP9iZGURnh/7houCSmoRQR0G+JvIhK5uFMY+J 1+40anxYqUASC7PZZsmLRT2m+RY31fl5onT2vgi7v7cKAn8SdQtMEelJyFbylOVMNUz3 sFA5wQimbkQVZ++LSVfh+ICNdDFjI0uwG+w+SoqoFqyVY2JXm5EMgPe5C43lpYHcLVFc 9Ppg== X-Gm-Message-State: APjAAAW/ZqyjCpuesymt/ET3uyI5+TXPwF5sxxTAha/Z3WFZkW11ts4n yNpc/8mmL26syCxYRzA+KuTzdQ== X-Google-Smtp-Source: APXvYqyvfppACA/wQQ9m2AZ5HWUcrNc3GHiM0R7YJTlBzosPxx0kVJGxNq++Gg0R32prI1vqFdSrTA== X-Received: by 2002:a17:902:42d:: with SMTP id 42mr3675054ple.228.1565106334931; Tue, 06 Aug 2019 08:45:34 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f27sm71669113pgm.60.2019.08.06.08.45.34 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 08:45:34 -0700 (PDT) Date: Tue, 6 Aug 2019 08:45:27 -0700 From: Stephen Hemminger To: Pavan Nikhilesh Bhagavatula Cc: Andrew Rybchenko , Jerin Jacob Kollanukkaran , John McNamara , "Marko Kovacevic" , Thomas Monjalon , Ferruh Yigit , "dev@dpdk.org" Message-ID: <20190806084527.0bce82d0@hermes.lan> In-Reply-To: References: <20190806080206.1572-1-pbhagavatula@marvell.com> <20190806080206.1572-2-pbhagavatula@marvell.com> <798d0b07-9196-2b60-b395-ac5f01c391d7@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [RFC 1/3] ethdev: add ptype as an Rx offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 6 Aug 2019 14:31:43 +0000 Pavan Nikhilesh Bhagavatula wrote: > >-----Original Message----- > >From: Andrew Rybchenko > >Sent: Tuesday, August 6, 2019 2:30 PM > >To: Pavan Nikhilesh Bhagavatula ; Jerin > >Jacob Kollanukkaran ; John McNamara > >; Marko Kovacevic > >; Thomas Monjalon > >; Ferruh Yigit > >Cc: dev@dpdk.org > >Subject: [EXT] Re: [dpdk-dev] [RFC 1/3] ethdev: add ptype as an Rx > >offload > > > >External Email > > > >---------------------------------------------------------------------- > >On 8/6/19 11:02 AM, pbhagavatula@marvell.com wrote: =20 > >> From: Pavan Nikhilesh > >> > >> Add ptype to DEV_RX_OFFLOAD_* flags which can be used to =20 > >enable/disable =20 > >> packet type parsing. > >> > >> Signed-off-by: Pavan Nikhilesh =20 > > > >I like the idea. I think there are few more Rx features which > >lack Rx offload bit: > > =C2=A0- delivery of RSS hash in mbuf (it is not always required when > > =C2=A0=C2=A0 RSS is used to distribute packets across Rx queues) =20 >=20 > Especially when applications use custom hash functions to store flows. >=20 > > =C2=A0- maybe Rx mark, since it is an extra information which could > > =C2=A0=C2=A0 be passed by NIC to CPU and it is better to know in advance > > =C2=A0=C2=A0 at Rx queue setup if it should be requested and processed = =20 >=20 > Are you referring to RTE_FLOW_ACTION_TYPE_MARK? >=20 > > > >API breakage should be considered here. I think it is OK to > >introduce it in the next release cycle in a dummy way which > >does not affect packet type delivery for existing PMDs > >(i.e. add offload capability and advertise in PMD, but do not > >take it into account when Rx mbuf is filled in) and > >submit deprecation notice that it may be taken into account > >by PMDs in 20.02 to avoid packet type delivery if the offload > >is not requested. It will allow applications to make transition > >smoother. =20 >=20 > Couldn=E2=80=99t agree with you more. I could extend the current RFC to i= nclude=20 > RSS and RX mark as we would be modifying the same offload fields across=20 > all drivers. Easier for PMD maintainers too. >=20 > > > >Acked-by: Andrew Rybchenko =20 >=20 I would rather the ptype offload be always on and handled in software for drivers that don't do it.