From: Jasvinder Singh <jasvinder.singh@intel.com>
To: dev@dpdk.org
Cc: cristian.dumitrescu@intel.com
Subject: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight
Date: Tue, 6 Aug 2019 12:49:51 +0100 [thread overview]
Message-ID: <20190806114951.62131-1-jasvinder.singh@intel.com> (raw)
In-Reply-To: <20190731113322.135053-1-jasvinder.singh@intel.com>
The sched library checks the subport tc ov weight value regardless
of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not.
This fix allows application to always set valid tc ov weight value.
Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object")
error log
SCHED: pipe_profile_check: Incorrect value for tc ov weight
SCHED: rte_sched_port_check_params: Pipe profile check failed(-22)
Command "tmgr" failed.
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
v2:
- add fix line
- change title
examples/ip_pipeline/cli.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index f4c2be8b8..c6cf4204e 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -469,12 +469,10 @@ cmd_tmgr_pipe_profile(char **tokens,
return;
}
-#ifdef RTE_SCHED_SUBPORT_TC_OV
if (parser_read_uint8(&p.tc_ov_weight, tokens[19]) != 0) {
snprintf(out, out_size, MSG_ARG_INVALID, "tc_ov_weight");
return;
}
-#endif
for (i = 0; i < RTE_SCHED_BE_QUEUES_PER_PIPE; i++)
if (parser_read_uint8(&p.wrr_weights[i], tokens[20 + i]) != 0) {
--
2.21.0
next prev parent reply other threads:[~2019-08-06 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 11:33 [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli Jasvinder Singh
2019-07-31 12:19 ` Dumitrescu, Cristian
2019-08-06 10:42 ` Thomas Monjalon
2019-08-06 11:50 ` Singh, Jasvinder
2019-08-06 11:49 ` Jasvinder Singh [this message]
2019-08-06 13:26 ` [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight Thomas Monjalon
2019-09-04 17:26 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806114951.62131-1-jasvinder.singh@intel.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).