From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B91C7A00E6 for ; Wed, 7 Aug 2019 07:53:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 428D7378B; Wed, 7 Aug 2019 07:53:18 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 57FE83576 for ; Wed, 7 Aug 2019 07:53:16 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id y8so39003047plr.12 for ; Tue, 06 Aug 2019 22:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zemblJM3TffOXfxEAHtS1K78kJFkcy6w6FXMNatD/IY=; b=LCuEejuTG1wj3+jvFhIqJG7wZY4XSrG2Paoj6FASqksPQCPnhxixOQHC3cmt7PyZaJ 5BbP25eixcPhdW+sHFVqzzMOF2YDee1Vdx67z0dEPOU98wsQ/3gKAdAjahlroGV4W4/j 0WIfwpmvUJFJhxpO0sqXnKZ8kBa5Hm0kf+UOH8W1kyI6lTpdnBclb2l5e3GDIUE4FVXm lyqf1DDyTHoSnaZjKWWE+elSid0PootrFEhr42zy8T/LuMPx/R7YOhjl3lbEkwA9iy5k QHIEQxfCDEGoFZ2EJeVDTZZJdNVNas2/ckFGGzPgrvjXtbdOHquk0T1ol8j29BvC2ApO Q41g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zemblJM3TffOXfxEAHtS1K78kJFkcy6w6FXMNatD/IY=; b=rtDQkCGo65BZnJPsjbgXZhIOf8t64vPm3j92D9mWk+UrZXZ3WdgYhd4Y9W2oML3vsM 1quQVS+AQv59jDy26+cXzZihTDnpv8dxo3TSAtBhXN+QMhHKDQfMARkzomgOrdbJdNwQ yG0WbNYVH0wzcdEZAYz3AFmdQco9Uf0PcPmD5BCrM3f/fT3xgnGmeWOZ+OLxLiAiGqNl sWiljWxoXjNbsCvUuHpVzDV7p59FRFxJPu3/2OyUO+LrTbBvEgBCMwJs4/eS253p7MJ9 ioed1PcMdZjJ9AP/Korw+i4RGovKvuZmX3hUr5pKAZZsSsW+8rnUqPikT1BsZoj1nUgT SX3w== X-Gm-Message-State: APjAAAWySS69QlCZ52Jom0TITdpQbDWNXy4iuy/pgNplzQ8gP8K23yCy GDdvx5A40vBjRIq15LExHEgg3w== X-Google-Smtp-Source: APXvYqzxPoshrn5RgPD+8gz5MS8mIgyHY+T0/ulOUe0erDtGyUQWWU4SyMU+Qspebu+P3qJzi/QiBg== X-Received: by 2002:aa7:9dcd:: with SMTP id g13mr7785186pfq.204.1565157195267; Tue, 06 Aug 2019 22:53:15 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i14sm138755328pfk.0.2019.08.06.22.53.14 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 22:53:15 -0700 (PDT) Date: Tue, 6 Aug 2019 22:53:08 -0700 From: Stephen Hemminger To: Matan Azrad Cc: "dev@dpdk.org" , Stephen Hemminger Message-ID: <20190806225308.736f15ef@hermes.lan> In-Reply-To: References: <20190726165054.24078-1-stephen@networkplumber.org> <20190802025826.1174-1-stephen@networkplumber.org> <20190802025826.1174-2-stephen@networkplumber.org> <20190802085301.02ab5b55@hermes.lan> <20190805090054.1511b033@hermes.lan> <20190806083955.59124799@hermes.lan> <20190806160913.62e0d15d@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 7 Aug 2019 05:38:42 +0000 Matan Azrad wrote: > From: Stephen Hemminger > > Sent: Wednesday, August 7, 2019 2:09 AM > > To: Matan Azrad > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: Re: [dpdk-dev] [PATCH v5 1/4] > > examples/multi_process/client_server_mp: check port validity > > > > On Tue, 6 Aug 2019 20:03:22 +0000 > > Matan Azrad wrote: > > > > > > > > > > The DPDK has lots of hard coded assumptions of all ports fitting in 64 bits. > > > > Examples include testpmd/parameters.c etc. > > > > > > Yes, I understand, but the user should know not to change the default > > > value of RTE_MAX_ETHPORTS, at least it should be documented. > > > > > > > The original concept of a small set of assigned values for portid is > > > > not going to scale. It really should have been more like ifindex; > > > > something that is not used by common API's much larger range; and > > assigned purely sequentially. > > > > > > > > The API's should all be using names, but the DPDK port naming is > > > > also a mess... > > > > > > Port ID is OK, user can run port info, then to find the wanted port ID and > > configure it by port id list\bitmap. > > > > > > > > > The examples are toy programs. If user changes RTE_MAX_ETHPORTS it will > > break lots of other places. Why put more checks in the examples. Sorry, it > > really would not help to pretend that fixing the example is going to help this. > > > Agree that it is not needed to fix all the places now. > It is better just to update the example documentation that RTE_MAX_ETHPORTS must not be changed when running this application. > > I will ack your series(v7) , Consider to update the doc if you want to be completely perfect here. Perhaps the right place to tell the users is somewhere in the documentation? One place would be here: diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index f19c1389b6af..a847d9ceda22 100644 --- a/doc/guides/faq/faq.rst +++ b/doc/guides/faq/faq.rst @@ -195,3 +195,8 @@ Why can't my application receive packets on my system with UEFI Secure Boot enab If UEFI secure boot is enabled, the Linux kernel may disallow the use of UIO on the system. Therefore, devices for use by DPDK should be bound to the ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. + +What is the maximum number of ethernet devices? +----------------------------------------------- + +The limit on the number of Ethernet devices is controlled by the RTE_MAX_ETHPORTS configuration setting. Since many of the applications use a 64 bit value for port mask; the current upper limit is 64 ports.