From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D238A00E6 for ; Wed, 7 Aug 2019 17:27:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32AF02BE1; Wed, 7 Aug 2019 17:27:29 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 3C65B2BCE for ; Wed, 7 Aug 2019 17:27:28 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id c14so41255385plo.0 for ; Wed, 07 Aug 2019 08:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BHyuluwkJ21p5ugVMdvXKDiZpWtExg6jt1+YmiIJ6gM=; b=EBKAICU1uNCXU1PNe2un3TkiPZoRm1kKyNiiDZL5jMCoFl0nrEA1vDDrZy6MgT0KUo IB7gz7iRKSWscn3kJjQauzZA/ULMqsOu5t08mf+L8Ex/RgE4w9Iond7aq5btygsxSbW8 +K1FviHDi5oH6J7TUVAf4RJlAfgKXiRA3nxpVn0NigafNqHmplzjVgxZ14fb/vbjS/dV hHFnxgYvs/pW6fYP8Inb59+/QBkvU7BuAJlfrGuHJktmQ2WbkNYkX/9KGntU30QR7294 rM7v4Ftipkciv22VokXseEwW0jzPEFDq0sNmWxzMzfrmJ66ZAyKbZdiMe+UG3SncBirG jlJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BHyuluwkJ21p5ugVMdvXKDiZpWtExg6jt1+YmiIJ6gM=; b=r+Y2SxD/SklmoadTfc8Acb5GGMChiP8gRPQdQmiIzB1Dypi7OA2azpPdNydCAOe/ac R7NLEZ2Qk5hpPHf6PQr1bfgMsJDgBlEzzuhKA0R8TlZOpsgx9s1qLJUehnFGsbRKUuFO qwPgkKJMj8CD51OhmtuswG8GwafvWlxF0yYzQkMNy/FA2bUa8RPPWvmr9X5TDryeo9B/ v6HL3WVU2Cz7Pu0/hml9r2Hi+jKo3DVYwS31SuFrLPUuAXeAssxv2xj53weSczqzjqcF Q1VM2y7ePedtL3GZbNZkTDK84BBDQ4CdFzVzJBEUwkD/tQFK5sCLmPk0vGH14pQrddzQ H6ug== X-Gm-Message-State: APjAAAUGEcaVT+FDjYIpnk9NxcjO32erzhfDxhzLzL2Dm4C0+ONU6jOU 56l0S6J0fkBtk8l478OHADpwhw== X-Google-Smtp-Source: APXvYqxscQQvfjJDOhMkXvArF4aCqbVH3ErsaIaaKqBr422HJsjfAGRRoQ/zOr8CG02ZZwIKZM5DIA== X-Received: by 2002:aa7:9407:: with SMTP id x7mr10196790pfo.163.1565191647409; Wed, 07 Aug 2019 08:27:27 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 22sm26340852pgl.0.2019.08.07.08.27.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 07 Aug 2019 08:27:27 -0700 (PDT) Date: Wed, 7 Aug 2019 08:27:20 -0700 From: Stephen Hemminger To: Gagandeep Singh Cc: dev@dpdk.org, thomas@monjalon.net, anatoly.burakov@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, Nipun Gupta Message-ID: <20190807082720.68f4d3f4@hermes.lan> In-Reply-To: <20190807101204.21614-1-g.singh@nxp.com> References: <20190807101204.21614-1-g.singh@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 7 Aug 2019 15:42:04 +0530 Gagandeep Singh wrote: > DPDK currently is supporting maximum 3 hugepage, > sizes whereas system can support more than this e.g. > 64K, 2M, 32M and 1G. > > Having these four hugepage sizes available to use by DPDK, > which is valid in case of '--in-memory' EAL option or > using 4 separate mount points for each hugepage size; > hugepage_info_init() API reports an error. > > This change increases the maximum supported mount points > to 4. > > Signed-off-by: Gagandeep Singh > Signed-off-by: Nipun Gupta > --- > > On ARM platform when the translation granule is 4KB, > there are 4 hugepage sizes supported. > On kernel 5.2, we can see below directories in > /sys/kernel/mm/hugepages: > > hugepages-1048576kB > hugepages-2048kB > hugepages-32768kB > hugepages-64kB > > lib/librte_eal/common/eal_internal_cfg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h > index edff09d07..abb7ec913 100644 > --- a/lib/librte_eal/common/eal_internal_cfg.h > +++ b/lib/librte_eal/common/eal_internal_cfg.h > @@ -15,7 +15,7 @@ > > #include "eal_thread.h" > > -#define MAX_HUGEPAGE_SIZES 3 /**< support up to 3 page sizes */ > +#define MAX_HUGEPAGE_SIZES 4 /**< support up to 4 page sizes */ At least this is hidden in internal config.