From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56509A00E6 for ; Wed, 7 Aug 2019 10:34:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3161F4C88; Wed, 7 Aug 2019 10:34:30 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7F467378B for ; Wed, 7 Aug 2019 10:34:28 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 01:34:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,356,1559545200"; d="scan'208";a="174435566" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by fmsmga008.fm.intel.com with ESMTP; 07 Aug 2019 01:34:26 -0700 Date: Wed, 7 Aug 2019 16:33:55 +0800 From: Ye Xiaolong To: Congwen Zhang Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org Message-ID: <20190807083355.GA73775@intel.com> References: <1565160199-16087-1-git-send-email-zhang.congwen@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565160199-16087-1-git-send-email-zhang.congwen@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix offset value check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 08/07, Congwen Zhang wrote: >The "and" condition offset == 0 && offset == NVM_INVALID_PTR > can never be true. A fix tag is missing here, you can refer to other fix commits in git log history. and also cc stable@dpdk.org. > >Signed-off-by: Congwen Zhang >--- > drivers/net/ixgbe/base/ixgbe_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c >index fb50719..e2ffbe6 100644 >--- a/drivers/net/ixgbe/base/ixgbe_common.c >+++ b/drivers/net/ixgbe/base/ixgbe_common.c >@@ -5040,7 +5040,7 @@ void ixgbe_get_oem_prod_version(struct ixgbe_hw *hw, > hw->eeprom.ops.read(hw, NVM_OEM_PROD_VER_PTR, &offset); > > /* Return is offset to OEM Product Version block is invalid */ >- if (offset == 0x0 && offset == NVM_INVALID_PTR) >+ if ((offset == 0x0) || (offset == NVM_INVALID_PTR)) > return; > > /* Read product version block */ >-- >1.8.3.1 > For the patch, you can add my ack in next version. Acked-by: Xiaolong Ye