From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F984A00E6 for ; Wed, 7 Aug 2019 10:57:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6954D3257; Wed, 7 Aug 2019 10:57:39 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B1BCB3256 for ; Wed, 7 Aug 2019 10:57:37 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 01:57:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,357,1559545200"; d="scan'208";a="176128863" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by fmsmga007.fm.intel.com with ESMTP; 07 Aug 2019 01:57:34 -0700 Date: Wed, 7 Aug 2019 16:57:03 +0800 From: Ye Xiaolong To: David Marchand Cc: Congwen Zhang , Wenzhuo Lu , "Ananyev, Konstantin" , dev Message-ID: <20190807085703.GC73775@intel.com> References: <1565164045-27992-1-git-send-email-zhang.congwen@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/07, David Marchand wrote: >On Wed, Aug 7, 2019 at 10:28 AM Congwen Zhang wrote: >> >> The type of rss_conf is struct ixgbe_rte_flow_rss_conf *, >> not struct rte_eth_rss_conf *. > >What is the actual issue? >Does it deserve a Fixes: tag? > >> >> Signed-off-by: Congwen Zhang >> --- >> drivers/net/ixgbe/ixgbe_flow.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c >> index 92377b8..b2a2bfc 100644 >> --- a/drivers/net/ixgbe/ixgbe_flow.c >> +++ b/drivers/net/ixgbe/ixgbe_flow.c >> @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[]) >> /* check if the next not void item is END */ >> act = next_no_void_action(actions, act); >> if (act->type != RTE_FLOW_ACTION_TYPE_END) { >> - memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)); >> + memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf)); > >Not sure what the maintainer prefers, but I would go with: >+ memset(rss_conf, 0, sizeof(*rss_conf)); > Since all other occurrences of memset in ixgbe_flow.c are using memset(aaa, 0, sizeof(struct bbb)) format, maybe it's better to make it consistent with others. Thanks, Xiaolong >> rte_flow_error_set(error, EINVAL, >> RTE_FLOW_ERROR_TYPE_ACTION, >> act, "Not supported action."); >> -- >> 1.8.3.1 >> > >-- >David Marchand