From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B84ECA00E6 for ; Thu, 8 Aug 2019 04:42:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B25812082; Thu, 8 Aug 2019 04:42:08 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 13D50F04; Thu, 8 Aug 2019 04:42:06 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 19:42:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,358,1559545200"; d="scan'208";a="165549740" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by orsmga007.jf.intel.com with ESMTP; 07 Aug 2019 19:42:04 -0700 Date: Thu, 8 Aug 2019 10:41:31 +0800 From: Ye Xiaolong To: Congwen Zhang Cc: wenzhuo.lu@intel.com, dev@dpdk.org, stable@dpdk.org, David Marchand Message-ID: <20190808024131.GD73775@intel.com> References: <1565228527-3969-1-git-send-email-zhang.congwen@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565228527-3969-1-git-send-email-zhang.congwen@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/08, Congwen Zhang wrote: >In function ixgbe_parse_rss_filter, memset(rss_conf, 0, >sizeof(struct rte_eth_rss_conf)) is using >memset(aaa, 0, sizeof(struct bbb)) format, >maybe it's better to make it consistent with others. Er...These comments are just for the style of memset, putting them in the commit log is not a good idea. Better to describe what issue you have met without this patch. Thanks, Xiaolong > >Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") >Cc: stable@dpdk.org > >Signed-off-by: Congwen Zhang >--- > drivers/net/ixgbe/ixgbe_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c >index 92377b8..b2a2bfc 100644 >--- a/drivers/net/ixgbe/ixgbe_flow.c >+++ b/drivers/net/ixgbe/ixgbe_flow.c >@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[]) > /* check if the next not void item is END */ > act = next_no_void_action(actions, act); > if (act->type != RTE_FLOW_ACTION_TYPE_END) { >- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)); >+ memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > act, "Not supported action."); >-- >1.8.3.1 >