* [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument
@ 2019-08-08 1:42 Congwen Zhang
2019-08-08 2:41 ` Ye Xiaolong
2019-10-24 7:44 ` Ye Xiaolong
0 siblings, 2 replies; 3+ messages in thread
From: Congwen Zhang @ 2019-08-08 1:42 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: dev, stable, Congwen Zhang
In function ixgbe_parse_rss_filter, memset(rss_conf, 0,
sizeof(struct rte_eth_rss_conf)) is using
memset(aaa, 0, sizeof(struct bbb)) format,
maybe it's better to make it consistent with others.
Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
drivers/net/ixgbe/ixgbe_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 92377b8..b2a2bfc 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
/* check if the next not void item is END */
act = next_no_void_action(actions, act);
if (act->type != RTE_FLOW_ACTION_TYPE_END) {
- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
+ memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
act, "Not supported action.");
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument
2019-08-08 1:42 [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument Congwen Zhang
@ 2019-08-08 2:41 ` Ye Xiaolong
2019-10-24 7:44 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2019-08-08 2:41 UTC (permalink / raw)
To: Congwen Zhang; +Cc: wenzhuo.lu, dev, stable, David Marchand
On 08/08, Congwen Zhang wrote:
>In function ixgbe_parse_rss_filter, memset(rss_conf, 0,
>sizeof(struct rte_eth_rss_conf)) is using
>memset(aaa, 0, sizeof(struct bbb)) format,
>maybe it's better to make it consistent with others.
Er...These comments are just for the style of memset, putting them in the commit
log is not a good idea. Better to describe what issue you have met without this
patch.
Thanks,
Xiaolong
>
>Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
>Cc: stable@dpdk.org
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>index 92377b8..b2a2bfc 100644
>--- a/drivers/net/ixgbe/ixgbe_flow.c
>+++ b/drivers/net/ixgbe/ixgbe_flow.c
>@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> /* check if the next not void item is END */
> act = next_no_void_action(actions, act);
> if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>+ memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> act, "Not supported action.");
>--
>1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument
2019-08-08 1:42 [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument Congwen Zhang
2019-08-08 2:41 ` Ye Xiaolong
@ 2019-10-24 7:44 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2019-10-24 7:44 UTC (permalink / raw)
To: Congwen Zhang; +Cc: wenzhuo.lu, dev, stable
On 08/08, Congwen Zhang wrote:
>In function ixgbe_parse_rss_filter, memset(rss_conf, 0,
>sizeof(struct rte_eth_rss_conf)) is using
>memset(aaa, 0, sizeof(struct bbb)) format,
>maybe it's better to make it consistent with others.
>
>Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
>Cc: stable@dpdk.org
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>index 92377b8..b2a2bfc 100644
>--- a/drivers/net/ixgbe/ixgbe_flow.c
>+++ b/drivers/net/ixgbe/ixgbe_flow.c
>@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> /* check if the next not void item is END */
> act = next_no_void_action(actions, act);
> if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>+ memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> act, "Not supported action.");
>--
>1.8.3.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-24 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08 1:42 [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument Congwen Zhang
2019-08-08 2:41 ` Ye Xiaolong
2019-10-24 7:44 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).