From: Andrius Sirvys <andrius.sirvys@intel.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, harry.van.haaren@intel.com,
cian.ferriter@intel.com, herakliusz.lipiec@intel.com,
Andrius Sirvys <andrius.sirvys@intel.com>
Subject: [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script
Date: Thu, 8 Aug 2019 15:37:52 +0100 [thread overview]
Message-ID: <20190808143753.16788-1-andrius.sirvys@intel.com> (raw)
In-Reply-To: <20190807130458.16754-1-andrius.sirvys@intel.com>
This commit removes the unnecesarry ast.literal_eval() function call
from the input handling, which now relies just on raw_input() to get
its input.
Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
Cc: andrius.sirvys@intel.com
Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
v2: Removed unnecessary comments
v3: Reduced scope of changes only to required Python 2 fix
Please note that the dpdk-telemetry-client.py script has a number of
issues with Python3 support. Fixing Python3 support is being deferred
to DPDK 19.11 release.
---
usertools/dpdk-telemetry-client.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index 4b0502ff9..60fe97af7 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -78,7 +78,7 @@ def requestMetrics(self): # Requests metrics for given client
def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
print("\nPlease enter the number of times you'd like to continuously request Metrics:")
- n_requests = int(ast.literal_eval(raw_input("\n:")))
+ n_requests = int(raw_input("\n:"))
print("\033[F") #Removes the user input from screen, cleans it up
print("\033[K")
for i in range(n_requests):
@@ -99,7 +99,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
print("[4] Unregister client")
try:
- self.choice = int(ast.literal_eval(raw_input("\n:")))
+ self.choice = int(raw_input("\n:"))
print("\033[F") #Removes the user input for screen, cleans it up
print("\033[K")
if self.choice == 1:
--
2.17.1
next prev parent reply other threads:[~2019-08-08 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 13:04 [dpdk-dev] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status Andrius Sirvys
2019-08-08 7:17 ` Thomas Monjalon
2019-08-08 14:37 ` Andrius Sirvys [this message]
2019-08-08 15:32 ` [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script Van Haaren, Harry
2019-08-08 15:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808143753.16788-1-andrius.sirvys@intel.com \
--to=andrius.sirvys@intel.com \
--cc=cian.ferriter@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=herakliusz.lipiec@intel.com \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).