From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8DF7A046B for ; Wed, 21 Aug 2019 06:43:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 979281BECB; Wed, 21 Aug 2019 06:43:11 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 1B9B41BEC7 for ; Wed, 21 Aug 2019 06:43:09 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id m9so619728pls.8 for ; Tue, 20 Aug 2019 21:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G+hQoXfwVBOtVHCt8rOynYoSaktSlQWE40HqkvSY50w=; b=zvmhlcazAmzhsGowvjdc1tAzZozZ6ScyjP9JFqb2sCrZ6zSOQCeyCaMbfYD3ibiUWm DD7ID5g7qJf8P9q6MKUhkSieOrFiPqiIdmdJT89GTQgtiOjmJyTXNq7X9LUyzYhaYlIK FP9H0LtvmJ2OX+YrEB3UzzWn4heQV6cDmHrL8HMTwo+HyQY7TEvS5sukQAUgWwEBk9eH UqCzsXamrB89ol5DzaHDmuOF8j3E5oer8aXcTIAlyGa+LZ5ygUx/QXxkVwPGM5Iysb1F fVvCgNZ5Lo5ErKlDEKG/R2kUQxjF4jOy3TU/EV5QWtrpmkLwB4YPsQ29RyQCWhmqvblb i55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G+hQoXfwVBOtVHCt8rOynYoSaktSlQWE40HqkvSY50w=; b=qya3BcPPqlZsvvMvxTLoba1S0x1jRc1qLHmaj37qFFQ9s0zYyCZr0OPWfss9eLUkKd wZefKGqNBk3ntzPfDcbv9Vy4WpaIucoLDCA0peIA0KdnFiD/C97JtsOwKWJZICgROiGb fuTsWT0u9YtqZTCvZ356e+iDtCBn+FRNWpJKDwjfTxDKVRV5TgeUYOhMfBVWltHCVH2b R5aFt8RuPdmD6ILsQxm1m4C3+PZNxNW7vXP1JX/7n6R1gkZhf95NDDp4/YL5VOL3RGwg /K3O2S1SbDfQpBKq1Z4DkTveC8OgurW1/isMT9bhTZsYe+yIQL7lgFDYnkB0S2fsKdc1 x9Wg== X-Gm-Message-State: APjAAAUUn6KTeNBvg/4A/20t+JV7lvymdYHWXJyHnUqfFYmp6q2xNFzp Z5CKM3l3HDRvJu6pMCj1OMV7Cg== X-Google-Smtp-Source: APXvYqw29iNcNfoRtxX0YjXSqDw4BJOIGR7SiwRzOdp73hfjPHHiiiBT/gS8wWF9bYJ8cqlblCh/gw== X-Received: by 2002:a17:902:9b86:: with SMTP id y6mr31929458plp.217.1566362588887; Tue, 20 Aug 2019 21:43:08 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i9sm19872770pgg.38.2019.08.20.21.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 21:43:08 -0700 (PDT) Date: Tue, 20 Aug 2019 21:43:06 -0700 From: Stephen Hemminger To: "Myers, Charles" Cc: Yong Wang , "dev@dpdk.org" Message-ID: <20190820214306.6ef7cd7f@hermes.lan> In-Reply-To: <1566353778-14774-1-git-send-email-charles.myers@spirent.com> References: <1566017542-26938-1-git-send-email-Charles.Myers@spirent.com> <1566353778-14774-1-git-send-email-charles.myers@spirent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net/vmxnet3: Added mtu_set() function to allow setting MTU. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 21 Aug 2019 02:16:58 +0000 "Myers, Charles" wrote: > > static int > +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > +{ > + if (dev->data->dev_started) { > + PMD_DRV_LOG(ERR, "Port %d must be stopped to configure MTU", > + dev->data->port_id); > + return -EBUSY; > + } > + > + return 0; > +} > + Don't you need to reset the rx ring to change mtu on the fly? At a minimum you need to communicate this value to host through the shared driver page.