From: Ray Kinsella <mdr@ashroe.eu>
To: dev@dpdk.org
Cc: mdr@ashroe.eu, bruce.richardson@intel.com,
vladimir.medvedkin@intel.com, john.mcnamara@intel.com,
marko.kovacevic@intel.com
Subject: [dpdk-dev] [PATCH v2 0/2] add abi version testing to app/test
Date: Thu, 22 Aug 2019 17:07:15 +0100 [thread overview]
Message-ID: <20190822160717.13584-1-mdr@ashroe.eu> (raw)
This patchset adds ABI version testing to the app/test unit test framework,
addressing two issues previously raised during ML conversations on ABI
stability;
1. How do we unit test still supported previous ABI versions?
2. How to we unit test inline functions from still supported previous ABI
versions?
Starting with rte_lpm, I did the following:-
* I reproduced mostly unmodified unit tests for the v2.0 ABI, taken from DPDK
2.2 and 17.02.
* I reproduced the rte_lpm interface header from v2.0, including the inline
functions and remapping symbols to their appropriate versions.
* I added support for multiple abi versions to the app/test unit test framework
to allow users to switch between abi versions (set_abi_version), without
further polluting the already long list of unit tests available in app/test.
The intention here is that in future as developers need to deprecate APIs, the
associated unit tests may move into the ABI version testing mechanism of the
app/test instead of being replaced by the latest set of unit tests as would be
the case today.
v2:
* Added LPM IPv6 test cases for the v2.0 ABI.
* Fixed a number of checkpatch errors, stop short of substantially reworking
the test code from the v2.0 ABI.
* Removed duplicating test cases published in the original v1 patch.
Ray Kinsella (2):
app/test: add abi version testing functionality
app/test: lpm abi version testing
app/test/Makefile | 12 +-
app/test/commands.c | 131 +-
app/test/meson.build | 6 +
app/test/test.c | 2 +
app/test/test.h | 48 +-
app/test/test_lpm.c | 3 +-
app/test/test_lpm6.c | 2 +-
app/test/test_lpm_perf.c | 293 +---
app/test/test_lpm_routes.c | 287 ++++
app/test/test_lpm_routes.h | 25 +
app/test/v2.0/dcompat.h | 30 +
app/test/v2.0/rte_lpm.h | 451 +++++
app/test/v2.0/rte_lpm6.h | 198 +++
app/test/v2.0/test_lpm.c | 1139 +++++++++++++
app/test/v2.0/test_lpm6.c | 1748 ++++++++++++++++++++
app/test/v2.0/test_lpm6_perf.c | 179 ++
app/test/v2.0/test_lpm_perf.c | 212 +++
app/test/v2.0/test_v20.c | 14 +
doc/guides/contributing/versioning.rst | 4 +
lib/librte_eal/common/include/rte_compat.h | 7 +
20 files changed, 4471 insertions(+), 320 deletions(-)
create mode 100644 app/test/test_lpm_routes.c
create mode 100644 app/test/test_lpm_routes.h
create mode 100644 app/test/v2.0/dcompat.h
create mode 100644 app/test/v2.0/rte_lpm.h
create mode 100644 app/test/v2.0/rte_lpm6.h
create mode 100644 app/test/v2.0/test_lpm.c
create mode 100644 app/test/v2.0/test_lpm6.c
create mode 100644 app/test/v2.0/test_lpm6_perf.c
create mode 100644 app/test/v2.0/test_lpm_perf.c
create mode 100644 app/test/v2.0/test_v20.c
--
2.17.1
next reply other threads:[~2019-08-22 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 16:07 Ray Kinsella [this message]
2019-08-22 16:07 ` [dpdk-dev] [PATCH v2 1/2] app/test: add abi version testing functionality Ray Kinsella
2019-08-22 16:07 ` [dpdk-dev] [PATCH v2 2/2] app/test: lpm abi version testing Ray Kinsella
2019-08-23 15:49 ` [dpdk-dev] [PATCH v2 0/2] add abi version testing to app/test Aaron Conole
2019-08-26 16:45 ` Ray Kinsella
2019-08-27 8:17 ` Bruce Richardson
2019-08-27 8:28 ` Ray Kinsella
2019-08-27 14:19 ` Ray Kinsella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822160717.13584-1-mdr@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).