From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A5D25A046B
	for <public@inbox.dpdk.org>; Fri, 23 Aug 2019 17:30:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2D2B91C066;
	Fri, 23 Aug 2019 17:30:12 +0200 (CEST)
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id A3C131C043;
 Fri, 23 Aug 2019 17:30:10 +0200 (CEST)
Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63)
 (envelope-from <linville@tuxdriver.com>)
 id 1i1BVx-0007We-2R; Fri, 23 Aug 2019 11:30:09 -0400
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
 by localhost.localdomain (8.15.2/8.14.6) with ESMTP id x7NFSkqt006246;
 Fri, 23 Aug 2019 11:28:46 -0400
Received: (from linville@localhost)
 by localhost.localdomain (8.15.2/8.15.2/Submit) id x7NFSk6e006245;
 Fri, 23 Aug 2019 11:28:46 -0400
Date: Fri, 23 Aug 2019 11:28:46 -0400
From: "John W. Linville" <linville@tuxdriver.com>
To: Abhishek Sachan <abhishek.sachan@altran.com>
Cc: dev@dpdk.org, stable@dpdk.org
Message-ID: <20190823152846.GA6221@tuxdriver.com>
References: <1566455136-8496-1-git-send-email-abhishek.sachan@altran.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1566455136-8496-1-git-send-email-abhishek.sachan@altran.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Subject: Re: [dpdk-dev] [PATCH] net/af_packet: fix for stale sockets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Aug 22, 2019 at 11:55:36AM +0530, Abhishek Sachan wrote:
> af_packet driver is leaving stale socket after device is removed.
> Ring buffers are memory mapped when device is added using rte_dev_probe.
> There is no corresponding munmap call when device is removed/closed.
> This commit fixes the issue by calling munmap
> from rte_pmd_af_packet_remove().
> 
> Bugzilla ID: 339
> Cc: stable@dpdk.org
> 
> Signed-off-by: Abhishek Sachan <abhishek.sachan@altran.com>
> Reviewed-by: John W. Linville <linville@redhat.com>

Confirmed...

Reviewed-by: John W. Linville <linville@redhat.com>

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.