From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BE2C3A0613
	for <public@inbox.dpdk.org>; Mon, 26 Aug 2019 11:21:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 838271BEFC;
	Mon, 26 Aug 2019 11:21:42 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 8E81A1BEF5
 for <dev@dpdk.org>; Mon, 26 Aug 2019 11:21:40 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 26 Aug 2019 02:21:39 -0700
X-IronPort-AV: E=Sophos;i="5.64,431,1559545200"; d="scan'208";a="184899615"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46])
 by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 26 Aug 2019 02:21:34 -0700
Date: Mon, 26 Aug 2019 10:21:31 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
 dpdk dev community <dev@dpdk.org>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@nxp.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Stephen Hemminger <sthemmin@microsoft.com>,
 "Ma, Liang J" <liang.j.ma@intel.com>,
 "Mccarthy, Peter" <peter.mccarthy@intel.com>,
 Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,
 Yongseok Koh <yskoh@mellanox.com>,
 Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 "Bie, Tiwei" <tiwei.bie@intel.com>,
 "Wang, Zhihong" <zhihong.wang@intel.com>, "Xu, Rosen" <rosen.xu@intel.com>,
 "Zhang, Tianfei" <tianfei.zhang@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Message-ID: <20190826092131.GA1731@bricha3-MOBL.ger.corp.intel.com>
References: <1565592813-5164-1-git-send-email-david.marchand@redhat.com>
 <9FC063DA-0039-4D1F-882C-57945F34D9A2@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9FC063DA-0039-4D1F-882C-57945F34D9A2@intel.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Subject: Re: [dpdk-dev] [PATCH] remove unneeded eal header inclusion
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Aug 12, 2019 at 12:25:03PM +0100, Wiles, Keith wrote:
> 
> 
> > On Aug 12, 2019, at 1:53 AM, David Marchand <david.marchand@redhat.com> wrote:
> > 
> > Restrict this header inclusion to its real users.
> > 
> > Fixes: 028669bc9f0d ("eal: hide shared memory config")
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> The only thing I would suggest is to add the name of the header file in the subject or body of the commit, as currently it is not obvious reading the commit title or body.
> 
> Regards,
> Keith

+1