DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking
@ 2019-08-28 12:27 Christian Ehrhardt
  2019-08-28 13:49 ` Luca Boccassi
  2019-08-28 13:53 ` Aaron Conole
  0 siblings, 2 replies; 17+ messages in thread
From: Christian Ehrhardt @ 2019-08-28 12:27 UTC (permalink / raw)
  To: dev, Kevin Laatz; +Cc: Luca Boccassi, Thomas Monjalon, Christian Ehrhardt

A while ago telemetry was added in 57ae0ec6 and it also added as-needed
to config/meson.build. This seems no more needed these days as due to other
build changes the ordering in buildlogs is:
  [...] -lrte_telemetry [...] -Wl,--no-as-needed [...]
Which means telemetry no more benefits from --no-as-needed anyway.

Overlinking problems get triggered by the meson generated pkgconfig which
will have:
   [...] -Wl,--no-as-needed <somelibsusedbydpdk>
This will overlink <somelibs> and in addition anything that follows
as it also doesn't wrap back to --as-needed. So if a projects includes
dpdk libs + <other> it will also consider <other> with --no-as-needed.

Fixes: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 config/meson.build | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/config/meson.build b/config/meson.build
index 2bafea530..58800a980 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -93,9 +93,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1)
 
 dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8)
 
-add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
-dpdk_extra_ldflags += '-Wl,--no-as-needed'
-
 # use pthreads
 add_project_link_arguments('-pthread', language: 'c')
 dpdk_extra_ldflags += '-pthread'
-- 
2.22.0


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2019-10-12 18:54 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-28 12:27 [dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking Christian Ehrhardt
2019-08-28 13:49 ` Luca Boccassi
2019-08-28 13:53 ` Aaron Conole
2019-08-28 14:48   ` Christian Ehrhardt
2019-08-28 15:14     ` Aaron Conole
2019-08-28 15:23       ` Aaron Conole
2019-08-29 10:18         ` Christian Ehrhardt
2019-08-29 15:25           ` Christian Ehrhardt
2019-08-29 15:30             ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2019-08-29 15:34               ` Bruce Richardson
2019-08-29 16:02                 ` Luca Boccassi
2019-09-02  7:09                   ` Christian Ehrhardt
2019-09-04  9:13                     ` Christian Ehrhardt
2019-09-04  9:18                       ` Bruce Richardson
2019-09-10  6:48                         ` Christian Ehrhardt
2019-09-12 13:43                           ` Christian Ehrhardt
2019-10-12 13:02                             ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).