DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, akhil.goyal@nxp.com, konstantin.ananyev@intel.com,
	bernard.iremonger@intel.com, declan.doherty@intel.com
Subject: Re: [dpdk-dev] [PATCH] security: add statistics definitions and update API
Date: Fri, 30 Aug 2019 07:33:27 -0700	[thread overview]
Message-ID: <20190830073327.71b0a997@hermes.lan> (raw)
In-Reply-To: <1567156760-29520-1-git-send-email-radu.nicolau@intel.com>

On Fri, 30 Aug 2019 10:19:20 +0100
Radu Nicolau <radu.nicolau@intel.com> wrote:

>  
>  struct rte_security_ipsec_stats {
> +	uint64_t ipackets;  /**< Successfully received IPsec packets. */
> +	uint64_t opackets;  /**< Successfully transmitted IPsec packets.*/
> +	uint64_t ibytes;    /**< Successfully received IPsec bytes. */
> +	uint64_t obytes;    /**< Successfully transmitted IPsec bytes. */
> +	uint64_t ierrors;   /**< IPsec packets receive/decrypt errors. */
> +	uint64_t oerrors;   /**< IPsec packets transmit/encrypt errors. */
>  	uint64_t reserved;
>  
>  };

Why not a second reserved field, then it will be 8*8 64 bytes long
which is cache aligned. And you will have a pair for future counters.

  reply	other threads:[~2019-08-30 14:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30  9:19 Radu Nicolau
2019-08-30 14:33 ` Stephen Hemminger [this message]
2019-09-02  9:20   ` Nicolau, Radu
2019-09-03  9:41 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2019-09-03 10:04   ` Anoob Joseph
2019-09-03 10:13     ` Nicolau, Radu
2019-09-03 11:26       ` [dpdk-dev] [EXT] " Anoob Joseph
2019-09-03 13:06 ` [dpdk-dev] [PATCH v3] " Radu Nicolau
2019-09-04  9:23   ` Akhil Goyal
2019-09-19 15:09     ` Akhil Goyal
2019-09-04  9:31   ` [dpdk-dev] [EXT] " Anoob Joseph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190830073327.71b0a997@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=akhil.goyal@nxp.com \
    --cc=bernard.iremonger@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=radu.nicolau@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).