From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1DF0A00E6 for ; Mon, 2 Sep 2019 08:30:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 000251D164; Mon, 2 Sep 2019 08:30:17 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D34BB1C1D0; Mon, 2 Sep 2019 08:30:16 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Sep 2019 23:30:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,457,1559545200"; d="scan'208";a="265943158" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.71]) by orsmga001.jf.intel.com with ESMTP; 01 Sep 2019 23:30:13 -0700 Date: Mon, 2 Sep 2019 14:27:47 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, amorenoz@redhat.com, xiao.w.wang@intel.com, dev@dpdk.org, jfreimann@redhat.com, stable@dpdk.org Message-ID: <20190902062746.GA13521@___> References: <20190829080000.20806-1-maxime.coquelin@redhat.com> <20190829080000.20806-7-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190829080000.20806-7-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 06/15] net/virtio: add skeleton for virtio vDPA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 29, 2019 at 09:59:51AM +0200, Maxime Coquelin wrote: > + > +RTE_PMD_REGISTER_PCI(net_virtio_vdpa, rte_virtio_vdpa); > +RTE_PMD_REGISTER_PCI_TABLE(net_virtio_vdpa, pci_id_virtio_vdpa_map); > +RTE_PMD_REGISTER_KMOD_DEP(net_virtio_vdpa, "* vfio-pci"); > + > +RTE_INIT(virtio_vdpa_init_log) > +{ > + virtio_vdpa_logtype = rte_log_register("pmd.net.virtio_vdpa"); We need to use pmd.net.virtio.init to enable the logs in virtio_pci.c when using virtio vdpa. Maybe naming above logtype e.g. "pmd.net.virtio.vdpa" will be more consistent? Regards, Tiwei > + if (virtio_vdpa_logtype >= 0) > + rte_log_set_level(virtio_vdpa_logtype, RTE_LOG_NOTICE); > +} > + > -- > 2.21.0 >