DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Zhang Xiao <xiao.zhang@intel.com>
Cc: dev@dpdk.org, wei.zhao1@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] net/ixgbe:fix wrong link status
Date: Mon, 2 Sep 2019 17:00:03 +0800	[thread overview]
Message-ID: <20190902090002.GC1665@intel.com> (raw)
In-Reply-To: <1567425132-59486-1-git-send-email-xiao.zhang@intel.com>

Hi, Xiao

On 09/02, Zhang Xiao wrote:
>The link status for 82599eb got from link status register was not correct,

So there is a HW issue, right?

Thanks,
Xiaolong

>check the enable/disable flag of tx laser when getting the link status,
>set the link status down if tx laser disabled since the tx laser flag
>could be set correctly when up/down the link status.
>
>Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
>Cc: stable@dpdk.org
>
>Signed-off-by: Zhang Xiao <xiao.zhang@intel.com>
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index 87d2ad0..fc06a1a 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -2864,6 +2864,7 @@ ixgbe_dev_set_link_up(struct rte_eth_dev *dev)
> 	} else {
> 		/* Turn on the laser */
> 		ixgbe_enable_tx_laser(hw);
>+		ixgbe_dev_link_update(dev, 0);
> 	}
> 
> 	return 0;
>@@ -2894,6 +2895,7 @@ ixgbe_dev_set_link_down(struct rte_eth_dev *dev)
> 	} else {
> 		/* Turn off the laser */
> 		ixgbe_disable_tx_laser(hw);
>+		ixgbe_dev_link_update(dev, 0);
> 	}
> 
> 	return 0;
>@@ -3967,6 +3969,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
> 	u32 speed = 0;
> 	int wait = 1;
> 	bool autoneg = false;
>+	u32 esdp_reg;
> 
> 	memset(&link, 0, sizeof(link));
> 	link.link_status = ETH_LINK_DOWN;
>@@ -3999,6 +4002,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
> 		return rte_eth_linkstatus_set(dev, &link);
> 	}
> 
>+	esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);
>+	if ((esdp_reg & IXGBE_ESDP_SDP3))
>+		link_up = 0;
>+
> 	if (link_up == 0) {
> 		intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
> 		return rte_eth_linkstatus_set(dev, &link);
>-- 
>2.7.4
>

  parent reply	other threads:[~2019-09-02  9:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 11:52 Zhang Xiao
2019-09-02  3:28 ` Zhao1, Wei
2019-09-02  9:00 ` Ye Xiaolong [this message]
2019-09-02  9:54 ` Ye Xiaolong
2019-10-29  5:33 ` [dpdk-dev] [v2] " Xiao Zhang
2019-11-04  5:32   ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190902090002.GC1665@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=wei.zhao1@intel.com \
    --cc=xiao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).