From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Xu, Rosen" <rosen.xu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init
Date: Tue, 3 Sep 2019 14:23:06 +0800 [thread overview]
Message-ID: <20190903062306.GF4325@intel.com> (raw)
In-Reply-To: <5941F446C088714A85408FA3132CFCBB0106BF60@SHSMSX105.ccr.corp.intel.com>
On 09/03, Pei, Andy wrote:
[snip]
> tmp = RTE_MAX(tmp, RTE_ETHER_MIN_MTU);
>
>>+ if (tmp > IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD)
>>+ tmp = IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD;
>
> tmp = RTE_MIN(tmp, IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD);
>
>in the definition of TRE_MIN and TRE_MAX, typeof() is used.
>RTE_ETHER_MIN_MTU is MACRO, your expression cause complie issue.
>
How about RTE_MAX(tmp, (uint32_t)RTE_ETHER_MIN_MTU)
Thanks,
Xiaolong
next prev parent reply other threads:[~2019-09-03 6:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 9:12 [dpdk-dev] [PATCH] " Andy Pei
2019-08-08 16:01 ` [dpdk-dev] [PATCH v2] " Andy Pei
2019-08-21 6:15 ` Ye Xiaolong
2019-09-02 3:01 ` Pei, Andy
2019-09-02 2:54 ` [dpdk-dev] [PATCH v3] " Andy Pei
2019-09-02 9:23 ` Ye Xiaolong
2019-09-03 2:34 ` Pei, Andy
2019-09-03 6:23 ` Ye Xiaolong [this message]
2019-09-03 6:29 ` Pei, Andy
2019-09-03 8:35 ` Ye Xiaolong
2019-09-03 8:46 ` Pei, Andy
2019-09-03 8:46 ` [dpdk-dev] [PATCH v4] " Andy Pei
2019-09-03 13:31 ` Ye Xiaolong
2019-09-04 2:05 ` Pei, Andy
2019-09-04 1:52 ` [dpdk-dev] [PATCH v5] " Andy Pei
2019-09-18 9:00 ` Ye Xiaolong
2019-09-24 8:59 ` Xu, Rosen
2019-09-24 9:38 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903062306.GF4325@intel.com \
--to=xiaolong.ye@intel.com \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).