* [dpdk-dev] [PATCH] net/ixgbe: remove redundant assignment
@ 2019-08-30 8:45 Yong Wang
2019-09-03 13:58 ` Ye Xiaolong
0 siblings, 1 reply; 2+ messages in thread
From: Yong Wang @ 2019-08-30 8:45 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: dev, Yong Wang
Since "link.link_duplex" has been assigned to ETH_LINK_FULL_DUPLEX just
before switch statement, the assignment in switch-case statement is
redundant. Remove it.
Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 03fc1f7..f328d7c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4138,7 +4138,6 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
link.link_speed = ETH_SPEED_NUM_10M;
else
link.link_speed = ETH_SPEED_NUM_100M;
- link.link_duplex = ETH_LINK_FULL_DUPLEX;
break;
case IXGBE_LINK_SPEED_100_FULL:
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: remove redundant assignment
2019-08-30 8:45 [dpdk-dev] [PATCH] net/ixgbe: remove redundant assignment Yong Wang
@ 2019-09-03 13:58 ` Ye Xiaolong
0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2019-09-03 13:58 UTC (permalink / raw)
To: Yong Wang; +Cc: wenzhuo.lu, dev
On 08/30, Yong Wang wrote:
>Since "link.link_duplex" has been assigned to ETH_LINK_FULL_DUPLEX just
>before switch statement, the assignment in switch-case statement is
>redundant. Remove it.
>
>Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
>
>Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index 03fc1f7..f328d7c 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -4138,7 +4138,6 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
> link.link_speed = ETH_SPEED_NUM_10M;
> else
> link.link_speed = ETH_SPEED_NUM_100M;
>- link.link_duplex = ETH_LINK_FULL_DUPLEX;
> break;
>
> case IXGBE_LINK_SPEED_100_FULL:
>--
>1.8.3.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel with 'Cc: stable@dpdk.org' added in the commit log.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-03 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 8:45 [dpdk-dev] [PATCH] net/ixgbe: remove redundant assignment Yong Wang
2019-09-03 13:58 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).