From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74D5AA2E1B for ; Tue, 3 Sep 2019 16:12:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96DBD1EB65; Tue, 3 Sep 2019 16:00:28 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 16BA81EB44 for ; Tue, 3 Sep 2019 16:00:26 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 07:00:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,463,1559545200"; d="scan'208";a="207091009" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by fmsmga004.fm.intel.com with ESMTP; 03 Sep 2019 07:00:25 -0700 Date: Tue, 3 Sep 2019 21:58:33 +0800 From: Ye Xiaolong To: Yong Wang Cc: wenzhuo.lu@intel.com, dev@dpdk.org Message-ID: <20190903135833.GB19294@intel.com> References: <1567154729-7183-1-git-send-email-wang.yong19@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567154729-7183-1-git-send-email-wang.yong19@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: remove redundant assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/30, Yong Wang wrote: >Since "link.link_duplex" has been assigned to ETH_LINK_FULL_DUPLEX just >before switch statement, the assignment in switch-case statement is >redundant. Remove it. > >Fixes: 82113036e4e5 ("ethdev: redesign link speed config") > >Signed-off-by: Yong Wang >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >index 03fc1f7..f328d7c 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -4138,7 +4138,6 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > link.link_speed = ETH_SPEED_NUM_10M; > else > link.link_speed = ETH_SPEED_NUM_100M; >- link.link_duplex = ETH_LINK_FULL_DUPLEX; > break; > > case IXGBE_LINK_SPEED_100_FULL: >-- >1.8.3.1 > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel with 'Cc: stable@dpdk.org' added in the commit log.