From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EFA10A2E1B
	for <public@inbox.dpdk.org>; Tue,  3 Sep 2019 16:20:41 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D79031EB8E;
	Tue,  3 Sep 2019 16:20:40 +0200 (CEST)
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 08CCD1C190
 for <dev@dpdk.org>; Tue,  3 Sep 2019 16:20:40 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id b16so17686408wrq.9
 for <dev@dpdk.org>; Tue, 03 Sep 2019 07:20:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:content-transfer-encoding:in-reply-to
 :user-agent; bh=X5cwfRdu7UZHg63Sw9+2RcEyLFY1OAQ2UqDkhIaacMg=;
 b=LQuCkeTnPaA13QwABEdLo91zNIQuTBphQTXHPbDhWHnFbiT0xUvQsWC6yEdtsj3jL1
 dbgbfAQEyhPKnSeO5xY5RGdjMNe1aoB2WntvZaoiSEhOlX627KVId73TRE7+iaAdk8Q0
 GJydXHRvehyEiF1UPoEa+zOfpu/d61BDDFK+vtREeOQlD0BGcmd2jEJGiZpJ1ciwhEJQ
 KHCnOnoFE7hvUGx4JjLbwJjb3J9+BChsC1G15tUry0TSrHhFQg8GiineSwepGvj3oV/3
 u2XXASktNXZmzhXYMs2Q3M27VPsS6vMXQYupj8xqWrZRGOuWlk+yKyPQBVwBMjTLJcIY
 wJVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:content-transfer-encoding
 :in-reply-to:user-agent;
 bh=X5cwfRdu7UZHg63Sw9+2RcEyLFY1OAQ2UqDkhIaacMg=;
 b=gfIPYv1amvD7QJ9duu4afu+32FkcsDKq7PkXgz6eznUUvTszJMHgtihEmVemVeqNHP
 56eTzX48SP6FlURpBhr5BYCkzPaT8bDEaW7SzUzqxBl8rEx4VmmiJl9yMK656f+cIeEK
 9F46MvKCt0mhDW2SH8YbjPhFJVCtZYfUVtZkzRmZKgg55M1mFBMZQtgCg5EaH3nUE3fJ
 DRm+Iwy2tHr6AgRrOPlfzZUv0rXnGZHpRXh8/2dXWDBVa2C/TnSJmGfYm99sYyAGEiQd
 NDFxxJSy3XysGuEkzC9P4Ci67kMweH/fCUNPjApkt6yZyNavGuPbcEb5N/ED7Baz0vTr
 Sa3Q==
X-Gm-Message-State: APjAAAWaBwEM9K6beJ4r8RGysDUg7n0i5aMA3Ua/p3iNEUr39yA+9kRl
 7bqkDXjV8VIJ83JTXv2Wh9mN1Q==
X-Google-Smtp-Source: APXvYqz/wsqFgxRsZhsO3AfBNINnnbcXYBnDMbIypgSxm8lbP7gFHxPOZEVRX1vuQAR4AFUeWfbTsA==
X-Received: by 2002:a5d:4382:: with SMTP id i2mr27732114wrq.297.1567520439602; 
 Tue, 03 Sep 2019 07:20:39 -0700 (PDT)
Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.
 [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id r17sm17956265wrt.68.2019.09.03.07.20.38
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 03 Sep 2019 07:20:38 -0700 (PDT)
Date: Tue, 3 Sep 2019 16:20:37 +0200
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
Message-ID: <20190903142037.4simolvz4wdrsnfh@bidouze.vm.6wind.com>
References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com>
 <1567519051-28189-1-git-send-email-arybchenko@solarflare.com>
 <1567519051-28189-15-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1567519051-28189-15-git-send-email-arybchenko@solarflare.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v2 14/54] net/failsafe: check status of
 getting ethdev info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Andrew, Ivan,

I would have found more consistent merging this patch with the main
ethdev one. It is short enough, I'm not sure this warrants a patch on
its own.

In any case,
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

On Tue, Sep 03, 2019 at 02:56:48PM +0100, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
> 
> rte_eth_dev_info_get() return value was changed from void to
> int, so this patch modify rte_eth_dev_info_get() usage across
> net/failsafe according to its new return type.
> 
> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  drivers/net/failsafe/failsafe_ops.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
> index 96e05d4..b3df626 100644
> --- a/drivers/net/failsafe/failsafe_ops.c
> +++ b/drivers/net/failsafe/failsafe_ops.c
> @@ -866,6 +866,7 @@
>  {
>  	struct sub_device *sdev;
>  	uint8_t i;
> +	int ret;
>  
>  	/* Use maximum upper bounds by default */
>  	infos->max_rx_pktlen = UINT32_MAX;
> @@ -933,7 +934,9 @@
>  	FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) {
>  		struct rte_eth_dev_info sub_info;
>  
> -		rte_eth_dev_info_get(PORT_ID(sdev), &sub_info);
> +		ret = rte_eth_dev_info_get(PORT_ID(sdev), &sub_info);
> +		if (ret != 0)
> +			return;
>  
>  		fs_dev_merge_info(infos, &sub_info);
>  	}
> -- 
> 1.8.3.1
> 

-- 
Gaƫtan Rivet
6WIND