From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EAD3CA2E8D
	for <public@inbox.dpdk.org>; Thu,  5 Sep 2019 18:36:19 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C23B31F057;
	Thu,  5 Sep 2019 18:36:19 +0200 (CEST)
Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com
 [209.85.215.169]) by dpdk.org (Postfix) with ESMTP id B42F01F054
 for <dev@dpdk.org>; Thu,  5 Sep 2019 18:36:18 +0200 (CEST)
Received: by mail-pg1-f169.google.com with SMTP id n190so1723770pgn.0
 for <dev@dpdk.org>; Thu, 05 Sep 2019 09:36:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=b/WvGpv6cNrMO7EbdqjgohxWOiY/XuDVEbjnyu3ltfU=;
 b=kbBVCJ76eK/vYGykTWoDIiySItC0guOdetN5BYlYY/caFoCq2Oqke3R+jsbP9DZDSZ
 31D1eNCrsNKI4/XAQYoLOK++RGpzoA9Evo1YlanI5/OZGwo5tKx4eSQHFgFZJq5TEB0w
 Vq8BnP16GY7x2IUZoMnVS+zqL22HyWPwXPs8sjyQn3qobYr/2rTB2PKFG+owvtoiY0gw
 PGmr9bw8kSSzy4ArushMvBP07tzkstwRLI5Lbum8NFa3M4AwbH9YU1NY8gZFER6ik0fu
 zIhC/Qjds2aKZe2tD/gDCc/2SgrDreOjXcKRN7L+khPyb2pD990cF1Z0zjKoqmHj/OAQ
 LHyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=b/WvGpv6cNrMO7EbdqjgohxWOiY/XuDVEbjnyu3ltfU=;
 b=lfV/8klQ3eMG34+Col6ir38MiI3vf9ktLeFi46rPNQYxYiADZuTmRpXWKY4pIBGj2l
 VUvp2X2yWcJOTcwltrGs8RU9ajjPh7sMXaV1QY3Isg4vBRJZc5HVG5Qkq96hyAlL2g9Q
 o0zrnihDXJHDOkyiu4CEvBWygkqas0bz0aeHbz0xoN71wkVSXNDf+2bWX49GG5qO8cVZ
 jj2CvCLtMw8/kwFH5jIuyz/8jbWfjqpa8kMNYAV1DkjVX4aHzCOB54YG4uamiyUYmSO1
 kkLCGs8sMQGsnGIR6ecb/037GBeTTf3LtKV68FQ6q5fN+VLQH8/Eooa/OrIpg78oXW7c
 j5sw==
X-Gm-Message-State: APjAAAXKhKBiVBZtWJcOAn+ZCDv7yPhbd0G+ioTd7p4GTeNNDcyOxOdq
 qwl9DApen6K2EIsL9d9HdIS/U2MDfPI=
X-Google-Smtp-Source: APXvYqwu/PjwfTll9/0rG8k8rxQEwtTvfcGXSJNJYSw5157yzo4O27wb/61mY98YFp2IP8nVcXFUbQ==
X-Received: by 2002:a17:90a:ad88:: with SMTP id
 s8mr4620152pjq.53.1567701377702; 
 Thu, 05 Sep 2019 09:36:17 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id t125sm3975319pfc.80.2019.09.05.09.36.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 05 Sep 2019 09:36:17 -0700 (PDT)
Date: Thu, 5 Sep 2019 09:36:15 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>, <dev@dpdk.org>, Ivan Ilchenko
 <Ivan.Ilchenko@oktetlabs.ru>
Message-ID: <20190905093615.2c3bbb57@hermes.lan>
In-Reply-To: <1567699852-31693-3-git-send-email-arybchenko@solarflare.com>
References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com>
 <1567699852-31693-3-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of
 promiscuous mode switch
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 5 Sep 2019 17:10:40 +0100
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> +		if (ret != 0) {
> +			ERROR("Failed to apply promiscuous mode");
> +			return ret;
> +		}

Just return the error as normal and let caller deal with it.
Additional logging is not necessary.