From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2F44A2E8D for ; Thu, 5 Sep 2019 18:40:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F2A81F073; Thu, 5 Sep 2019 18:40:17 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 352AE1F057 for ; Thu, 5 Sep 2019 18:40:16 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id q5so2087629pfg.13 for ; Thu, 05 Sep 2019 09:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d5510UsWry9GLD7AWrFMhDSv8EtY9wGS6iVzTcHPBhA=; b=1OrUrttqDggp88yevS8K1ENjpXfsm0uuNiv71TupfngPCj7BwqM5ZzppsYtQE7OIw/ 6PePuC8SDhRPgzzcj78QT0JQQ5NrVbdSeJDh6rW9hgrFbIt/+oSR2wz4DA3F7iqLjxxR /1yBQoO3RBqLvJ3VId8g3M8SqT9PLRLpqU+SODl1DZzNxtnFyvTxR5YdAgeHC2tgWTBJ 2udpv9u0MKV959xgBmAmuoTz9u+6ow0tW0dVOeUt8Qd3kmYQQ8c8s5bJy/HYweI42rev Tv8M/U32jACU7SstvgaXlFriHaAsv2I5LsipjEr3t04sQYk8SjD1oTa0HqAyce47MTcO B28g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d5510UsWry9GLD7AWrFMhDSv8EtY9wGS6iVzTcHPBhA=; b=sqmUaD66D4F3YRtrkrlbbjTFR5j3BOh1sKtFGju5OhphNXuTIbBtcm+aQxiaR3haEQ JtZLhT2h7jAmHbVEA2tI4Jz2odgmA22hUa4TD5dxbSUPO847TDOV3X5V64DEAXBprmDK QsZhkMwR/54KlpPCiOH/ocR/M5wZZdrvknVdqBcwAg6kDXmT6u7Df3UDpLIjCwvG4TMv 2nzqLwvCaVCzYDhDSv5dqwj55P3m4AawHwXYQ7GmK0CMazVGAfCVA3Nju5eQRIarRp8n AaquJ1TgECX0t3Q6GKrW6vRyjUzKRszTspPJFSewm9og339iUOr4BqqpIZnSeBFJgFq+ zcrw== X-Gm-Message-State: APjAAAWVn3XEEqfm4hUlQa9wRms9Ik870ndJlPCpKLcYrtyA9aqTjGG9 VJK8D3iTkgpCu8UexbfY/6njSQ== X-Google-Smtp-Source: APXvYqzv5DMhlxmEC71U1RFAg1jYy9yC/8JQX7YHBQoyMjiZNLmOL1Uw1FSaK3KV0Of762ETQBccnw== X-Received: by 2002:a63:ed50:: with SMTP id m16mr3994394pgk.209.1567701615316; Thu, 05 Sep 2019 09:40:15 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x5sm3223549pfi.165.2019.09.05.09.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 09:40:15 -0700 (PDT) Date: Thu, 5 Sep 2019 09:40:13 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Gaetan Rivet , , Ivan Ilchenko Message-ID: <20190905094013.6038f374@hermes.lan> In-Reply-To: <1567699852-31693-3-git-send-email-arybchenko@solarflare.com> References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com> <1567699852-31693-3-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > value was changed from void to int, so this patch modify usage > of these functions across net/failsafe according to new return type. > > Try to keep promiscuous mode consistent across all active > devices in the case of failure. > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko In reality, failsafe's promiscious mode is actually a lie. The only common use case of failsafe is on Azure/Hyper-V and in a guest setting promiscuous is not allowed. That is why there is no promiscuous setting in netvsc PMD.