From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3A3AEA2E1B
	for <public@inbox.dpdk.org>; Thu,  5 Sep 2019 15:28:50 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1C8C31EF88;
	Thu,  5 Sep 2019 15:28:49 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 56E861EF87
 for <dev@dpdk.org>; Thu,  5 Sep 2019 15:28:47 +0200 (CEST)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 05 Sep 2019 06:28:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,470,1559545200"; d="scan'208";a="187975283"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5])
 by orsmga006.jf.intel.com with ESMTP; 05 Sep 2019 06:28:45 -0700
Date: Thu, 5 Sep 2019 21:26:46 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Wang, Ying A" <ying.a.wang@intel.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
 "Yang, Qiming" <qiming.yang@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Zhao1, Wei" <wei.zhao1@intel.com>
Message-ID: <20190905132646.GK70700@intel.com>
References: <20190903221522.151382-1-ying.a.wang@intel.com>
 <20190903221522.151382-3-ying.a.wang@intel.com>
 <20190904144435.GC54897@intel.com>
 <44DE8E8A53B4014CA1985CEE86C07F2A0B988E93@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <44DE8E8A53B4014CA1985CEE86C07F2A0B988E93@SHSMSX101.ccr.corp.intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/05, Wang, Ying A wrote:
>
>For the previous indentation is not tab-aligned, I will add a separate code cleanup patch for these changes.
>
>> 
>> > {
>> > 	uint32_t cpy_count = 0;
>> > 	const struct rte_flow_item *pb = pattern, *pe = pattern; @@ -124,7
>> >+285,6 @@ ice_pattern_skip_void_item(struct rte_flow_item *items,
>> > 		items += cpy_count;
>> >
>> > 		if (pe->type == RTE_FLOW_ITEM_TYPE_END) {
>> >-			pb = pe;
>> 
>> seems this is some code cleanup, prefer a separate patch, not a strong opinion
>> though.
>
>OK, will add a separate patch for code cleanup.

Thanks, and please put the cleanup/fix patches at the beginning of your patchset.