From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C4CA2EDB for ; Fri, 6 Sep 2019 11:28:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5EC81F237; Fri, 6 Sep 2019 11:28:57 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id E02EE1F20D for ; Fri, 6 Sep 2019 11:28:56 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id g207so5717543wmg.5 for ; Fri, 06 Sep 2019 02:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=UTzU6/1ypZRCORhMU+MhvXGDB44EzkuxN41TefUDGBk=; b=U3SRc7SRHPTkqR5iFRRWFT7Y0JkMYW1Wj4DutZ+MeJ94iHo5xD7Zdc3nv8ExAMyZrs HunXe4vbY+zOa/EFkKBhpEYKPWI+23U1W12UpCxAtxaHyTgrlaGZ/A4/sEhaDIYh/cvU cHrJankEp+N9D47BfJunTPjQy6Kky7SLGch6z0bRMOw89E5uaZ+abnwCs5vJ/sSW5SZL 0bhxkPpYEAT8LKvb6y0zdvu5hkOW/Np/D6X8RyPt86dgPRLTWH86GcLBa+hu/iDBoqmy 6xKbXvSbvr4X4RjodZbe649CQJlxNcQnroFrrmQAAG9gmhQ8HfbmPGmbLFxmH0mYcx6C aVrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=UTzU6/1ypZRCORhMU+MhvXGDB44EzkuxN41TefUDGBk=; b=T40GM08BaJpAP2gmhUSzJxTXxfOk6C+wzZe6HfyxPzvY42kGAZjKVEVoUEPAXqFaZC isrFBI5LYTCNmlW9fwNSCLC3Wo0T9r5iYIUuFjPYb8WEGLFC+1Ki2O++n6o8Xc+Miafk Gqi1y8+01kao7WXMUZtF6+wjnTORMj8b+ctLgGX4u7Tzz9e6EwPsDJh2VCbkU2oCEE28 HhGjyCxu0GasDCNGrd4vhIMfJtO9h1L09VDFKHQRsgMONZNQ9EwcT5/bGYMxQPOFVcc3 qSI85Wi2Xzgrr6dOIZ536ZuV/xc87KFdh3tcdMCKchGK/Bcpb3J27QPlUjjm11p99b0V Odbw== X-Gm-Message-State: APjAAAWSgDmeyqyj9uR+Y+0vMaW2ECQ4iH+/QDC0ubFUp5KYBiL/Kbt9 ijzQ7FI+fvf1DfFbCB+uFVEkcQ== X-Google-Smtp-Source: APXvYqztvLCE7IDr1KeVhIQF1Ov3v//bRwfvi96sHeqqgImOgDN9tULO6pWtOZfVi4agomSB7WS88w== X-Received: by 2002:a7b:ce94:: with SMTP id q20mr4311464wmj.97.1567762136644; Fri, 06 Sep 2019 02:28:56 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z12sm4357156wrt.92.2019.09.06.02.28.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Sep 2019 02:28:56 -0700 (PDT) Date: Fri, 6 Sep 2019 11:28:54 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Andrew Rybchenko Cc: dev@dpdk.org, Ivan Ilchenko Message-ID: <20190906092854.dm7sv4wmfsozw5rs@bidouze.vm.6wind.com> References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <1567755066-31389-1-git-send-email-arybchenko@solarflare.com> <1567755066-31389-15-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1567755066-31389-15-git-send-email-arybchenko@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3 14/54] net/failsafe: check status of getting ethdev info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, Ivan, On Fri, Sep 06, 2019 at 08:30:26AM +0100, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_dev_info_get() return value was changed from void to > int, so this patch modify rte_eth_dev_info_get() usage across > net/failsafe according to its new return type. > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > Acked-by: Gaetan Rivet > --- > drivers/net/failsafe/failsafe_ops.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c > index 96e05d4dc4..b3df626aaa 100644 > --- a/drivers/net/failsafe/failsafe_ops.c > +++ b/drivers/net/failsafe/failsafe_ops.c > @@ -866,6 +866,7 @@ fs_dev_infos_get(struct rte_eth_dev *dev, > { > struct sub_device *sdev; > uint8_t i; > + int ret; > > /* Use maximum upper bounds by default */ > infos->max_rx_pktlen = UINT32_MAX; > @@ -933,7 +934,9 @@ fs_dev_infos_get(struct rte_eth_dev *dev, > FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { > struct rte_eth_dev_info sub_info; > > - rte_eth_dev_info_get(PORT_ID(sdev), &sub_info); > + ret = rte_eth_dev_info_get(PORT_ID(sdev), &sub_info); > + if (ret != 0) > + return; Similar to the promiscuous thread, I actually forgot about fs_err(); You should use it here as well. > > fs_dev_merge_info(infos, &sub_info); > } > -- > 2.17.1 > -- Gaëtan Rivet 6WIND