From: Marcin Zapolski <marcinx.a.zapolski@intel.com>
To: dev@dpdk.org
Cc: Marcin Zapolski <marcinx.a.zapolski@intel.com>
Subject: [dpdk-dev] [RFC 19.11 v2 0/3] Hide DPDK internal struct from public API
Date: Fri, 6 Sep 2019 15:18:10 +0200 [thread overview]
Message-ID: <20190906131813.1343-1-marcinx.a.zapolski@intel.com> (raw)
In-Reply-To: <20190730124950.1293-1-marcinx.a.zapolski@intel.com>
Several DPDK internal structures are exposed to direct access by user
applications. This patch removes them from public API, and makes core DPDK
functions that use them non-inline.
v2:
This patch set no longer makes internal DPDK functions non-inline. Instead
it splits the rte_eth_dev structure to private and public part and modifies
function arguments of rx and tx functions. This should bring less performance
impact, but at the cost of needing to modify every PMD to use new rx and tx
functions.
For testing purposes, the ixgbe and i40e drivers are modified to acommodate for
the changes.
Marcin Zapolski (3):
ethdev: hide key ethdev structures from public API
i40e: make driver compatible with changes in ethdev
ixgbe: make driver compatible with changes in ethdev
drivers/net/i40e/i40e_ethdev.c | 10 +-
drivers/net/i40e/i40e_ethdev.h | 1 +
drivers/net/i40e/i40e_ethdev_vf.c | 8 +-
drivers/net/i40e/i40e_rxtx.c | 119 ++--
drivers/net/i40e/i40e_rxtx.h | 33 +-
drivers/net/i40e/i40e_rxtx_vec_altivec.c | 23 +-
drivers/net/i40e/i40e_rxtx_vec_avx2.c | 45 +-
drivers/net/i40e/i40e_rxtx_vec_neon.c | 23 +-
drivers/net/i40e/i40e_rxtx_vec_sse.c | 23 +-
drivers/net/i40e/i40e_vf_representor.c | 12 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 30 +-
drivers/net/ixgbe/ixgbe_ethdev.h | 23 +-
drivers/net/ixgbe/ixgbe_rxtx.c | 111 ++--
drivers/net/ixgbe/ixgbe_rxtx.h | 9 +-
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 22 +-
drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 23 +-
drivers/net/ixgbe/ixgbe_vf_representor.c | 10 +-
lib/librte_bitratestats/rte_bitrate.c | 2 +-
lib/librte_bpf/bpf_pkt.c | 2 +-
lib/librte_ethdev/ethdev_private.c | 1 +
lib/librte_ethdev/ethdev_profile.h | 1 +
lib/librte_ethdev/rte_ethdev.c | 122 +++-
lib/librte_ethdev/rte_ethdev.h | 222 +++++---
lib/librte_ethdev/rte_ethdev_core.h | 531 +-----------------
lib/librte_ethdev/rte_ethdev_driver.h | 482 ++++++++++++++++
lib/librte_ethdev/rte_ethdev_version.map | 11 +
lib/librte_ethdev/rte_flow.c | 2 +-
lib/librte_ethdev/rte_mtr.c | 2 +-
lib/librte_ethdev/rte_tm.c | 2 +-
lib/librte_ethdev/rte_tm_driver.h | 1 +
.../rte_event_eth_rx_adapter.c | 2 +-
.../rte_event_eth_tx_adapter.c | 2 +-
lib/librte_eventdev/rte_eventdev.c | 2 +-
lib/librte_flow_classify/rte_flow_classify.h | 2 +-
.../rte_flow_classify_parse.h | 2 +-
lib/librte_gro/gro_tcp4.c | 2 +-
lib/librte_gro/gro_vxlan_tcp4.c | 2 +-
lib/librte_gro/rte_gro.c | 2 +-
lib/librte_gso/rte_gso.c | 2 +-
lib/librte_kni/rte_kni.c | 2 +-
lib/librte_latencystats/rte_latencystats.c | 2 +-
lib/librte_pdump/rte_pdump.c | 2 +-
lib/librte_port/rte_port_ethdev.c | 2 +-
lib/librte_telemetry/rte_telemetry.c | 2 +-
lib/librte_telemetry/rte_telemetry_parser.c | 2 +-
lib/librte_vhost/vhost.c | 2 +-
46 files changed, 1053 insertions(+), 885 deletions(-)
--
2.17.1
next prev parent reply other threads:[~2019-09-06 13:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 12:49 [dpdk-dev] [RFC 19.11 0/2] " Marcin Zapolski
2019-07-30 12:49 ` [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline Marcin Zapolski
2019-07-30 15:01 ` Jerin Jacob Kollanukkaran
2019-07-30 15:32 ` Bruce Richardson
2019-07-30 15:25 ` Stephen Hemminger
2019-07-30 15:33 ` Bruce Richardson
2019-07-30 15:54 ` Stephen Hemminger
2019-07-30 16:04 ` Wiles, Keith
2019-07-30 16:11 ` Bruce Richardson
2019-07-30 16:23 ` Stephen Hemminger
2019-07-30 12:49 ` [dpdk-dev] [RFC 19.11 2/2] ethdev: hide DPDK internal struct from public API Marcin Zapolski
2019-07-30 14:53 ` Ferruh Yigit
2019-09-06 13:18 ` Marcin Zapolski [this message]
2019-09-06 14:00 ` [dpdk-dev] [RFC 19.11 v2 0/3] Hide " Bruce Richardson
2019-09-06 13:18 ` [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures " Marcin Zapolski
2019-09-06 14:37 ` Ferruh Yigit
2019-09-09 8:07 ` Zapolski, MarcinX A
2019-09-09 9:59 ` Ferruh Yigit
2019-09-09 10:02 ` Zapolski, MarcinX A
2019-09-09 10:24 ` Ferruh Yigit
2019-09-09 11:41 ` Zapolski, MarcinX A
2019-09-14 10:34 ` Jerin Jacob
2019-09-06 17:24 ` Stephen Hemminger
2019-09-09 9:01 ` Zapolski, MarcinX A
2019-09-10 9:59 ` Zapolski, MarcinX A
2019-09-10 10:06 ` Bruce Richardson
2019-09-10 10:13 ` Zapolski, MarcinX A
2019-09-10 12:19 ` Bruce Richardson
2019-09-10 12:22 ` Zapolski, MarcinX A
2019-09-06 13:18 ` [dpdk-dev] [RFC 19.11 v2 2/3] i40e: make driver compatible with changes in ethdev Marcin Zapolski
2019-09-06 13:18 ` [dpdk-dev] [RFC 19.11 v2 3/3] ixgbe: " Marcin Zapolski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906131813.1343-1-marcinx.a.zapolski@intel.com \
--to=marcinx.a.zapolski@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).