From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75ACFA0471 for ; Sun, 8 Sep 2019 21:44:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 282E61E9CB; Sun, 8 Sep 2019 21:44:41 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 906391E9B3 for ; Sun, 8 Sep 2019 21:44:40 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id r17so11343359wme.0 for ; Sun, 08 Sep 2019 12:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TKPqtG94yu6bSGLbkCxPK38xS0qoSeIlRau73jRUG9I=; b=kTn34YCErL+51RIA+NH/g/alkQiXyS7o91fLbe4WpK3sB+kO5YW6m3yo3UdaS0jGLH Cf4aXR80KoqV1uO7DrbEW/fOU4vFz2FiBit7tJgscn1mnvFWsY/n7g2p2yjRryTYkwCC /hJwzqmqSYsKf9C+WPxgdhSnmaqfXTQLGCqsuevjcoQ7OR0xnyycf7SbTB3XF5LeuqpE +sjP0FnggazfJsJjmZt8DQX8MDvaUTzVO8bAaG6yv6FH3sYE6BFtQGKqLALxd5oKJNz1 ipeKqyO/eidfkE8LTwLy9ovjcM4u9yhLkHFbo9l2an3AD+RnOMJciP1AqUgO5u1A686o WeaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TKPqtG94yu6bSGLbkCxPK38xS0qoSeIlRau73jRUG9I=; b=ZFOMIO0DX1UpF7TNVwbRHYPel6tdg8CIs4qVwMIKZ0Xp/dvUP7WHbZuv0PsMuI3Xhd /kQ2tKcQlu+b9oPct2UQdYptvWVedvvNfFzpyvDr/EaPJE9Fp5UPmOfLO3Bzvz3oQmDA xWgyNjoJMXwGUC3UJ4pu/joMKoVrFtgBjlrc2GQ7Cb38wo4NMVfHbz/y5fP2+IpchN23 6FLPCkTRNJU4jgH2f4DRr39Jn2tYFSPh9Lvzi6hkM/87XXn/dqwnEROk5AqCVjGWYcIn aoCSSj3tq/ykPKyt7AscfESbIx3NiFCrmyNDlI1TGSOjbS4wiiN9bIhZJ4Vyd9C3IgUv FCUA== X-Gm-Message-State: APjAAAW1y4NJ8k8rEsB5JrYrwAinIndYO/NaCi4dznk+wevBi8mrHDBl ZmuDaEE8a2lA3w+ZGwVN/K2+RQ== X-Google-Smtp-Source: APXvYqw8g4L6fpLacLHvqeNC15aJFmYyVy2WoqTSAaJfQHg0E3Z4q+gcz5bBW0lB2CQUwdVnO8d8bA== X-Received: by 2002:a1c:6c19:: with SMTP id h25mr15104607wmc.64.1567971880168; Sun, 08 Sep 2019 12:44:40 -0700 (PDT) Received: from xps13 (110.8.30.213.rev.vodafone.pt. [213.30.8.110]) by smtp.gmail.com with ESMTPSA id n14sm35440588wra.75.2019.09.08.12.44.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Sep 2019 12:44:39 -0700 (PDT) Date: Sun, 8 Sep 2019 20:44:36 +0100 From: Stephen Hemminger To: Honnappa Nagarahalli Cc: olivier.matz@6wind.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, dev@dpdk.org, pbhagavatula@marvell.com, jerinj@marvell.com Message-ID: <20190908204436.52fd804b@xps13> In-Reply-To: <20190906190510.11146-3-honnappa.nagarahalli@arm.com> References: <20190828144614.25284-1-honnappa.nagarahalli@arm.com> <20190906190510.11146-1-honnappa.nagarahalli@arm.com> <20190906190510.11146-3-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/6] lib/ring: add template to support different element sizes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 6 Sep 2019 14:05:06 -0500 Honnappa Nagarahalli wrote: > Add templates to support creating ring APIs with different > ring element sizes. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang Understand the desire for generic code, but macro's are much harder to maintain and debug. Would it be possible to use inline code taking a size argument and let compiler optimizations with constant folding do the same thing. Sorry, I vote NO for large scale use of macro's.