From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36D71A2EDC for ; Mon, 9 Sep 2019 14:48:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADD5F1EAF5; Mon, 9 Sep 2019 14:48:41 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id C4C451D448 for ; Mon, 9 Sep 2019 14:48:39 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id h7so12684600wrw.8 for ; Mon, 09 Sep 2019 05:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=O4ZhUWVX6GqsWI5LI/nYbgeZy8m7C9gvaE6l/woDshg=; b=hqKXo3jYXr1ZrIeendsA0ouAkP8gNho2mF0kvxwopD/OdFuCk2hmtseoPTeGwtcTlr yIsuUTbb8TCsYZRY6XwgdddRHJ7zllrPC9yAmA8nCg4Vm3lyKvzAW++sTAOTcMrqF9qG sAZMDXVAdc3fyex47oJo9Yo2V/t6A5PhrQ5h1pXANDNbanJ2soS4Fk75q26LpRzqg1/5 cqJ/uaqe2NsUiQ6XudYDGaXxo5LSxHAoAaJB9J9pG4CBj2GdEmRHkizuj8Kxttr9Mrm8 IRwMQiYPZHIYxh+g2MSwsijPZGtwTHoa9Pbj653orgX8XTqfvmRfhHJmPItYT0psyTep Jq9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=O4ZhUWVX6GqsWI5LI/nYbgeZy8m7C9gvaE6l/woDshg=; b=noTQUFz1xaeXR2J2Jta2B0HJ1tTxWUtSq1VWk1nW/HfrakugDt36yTUNjPBvxRkmcN dMmhVI4P1JsevaI6IGlM6VttHV+bh6RVnscvYm9X072DjEaiBRB0ONkvOvKRnGhj1IWq B3uFE8Muovr7Twr1qyHICLyr++OXTYm6vgfQHwJoNEhnc4hSNmbD/PNPS+X5W25ycfCE HZdu0Z5NogLlQ+IOB343tMdfvODmOF5JgvpltWNup9NhAdFXw4ZNLC9lklN6xjE625Ln 2Iv5xfd1wsP+yTIVZhmz5Fg3W/O6sCV3PWAm1SL0o3nJjBKFaQnWAPTtGPM80qNKSlEW 8MsA== X-Gm-Message-State: APjAAAXTesyEKl4EHEh98SZgoAqZ01ImP5tWcvQ4HgHlab8hyJK2FIgZ emkHdULq5vqbFuICI0v2MTHX4A== X-Google-Smtp-Source: APXvYqx9umL5sWybmW7xrFlzZYG66pUmv5QsRYQgoNTv7pY3vVnF7SF6MDy76O04xkANmsyJmNz53w== X-Received: by 2002:adf:ef12:: with SMTP id e18mr18468268wro.65.1568033319523; Mon, 09 Sep 2019 05:48:39 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 74sm16258348wma.15.2019.09.09.05.48.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Sep 2019 05:48:38 -0700 (PDT) Date: Mon, 9 Sep 2019 14:48:37 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Andrew Rybchenko Cc: dev@dpdk.org, Ivan Ilchenko Message-ID: <20190909124837.uyhlbz5uv5uo7ffg@bidouze.vm.6wind.com> References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-3-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1568030331-16526-3-git-send-email-arybchenko@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 02/13] net/failsafe: check code of promiscuous mode switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Mon, Sep 09, 2019 at 12:58:39PM +0100, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > value was changed from void to int, so this patch modify usage > of these functions across net/failsafe according to new return type. > > Try to keep promiscuous mode consistent across all active > devices in the case of failure. > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko LGTM, Acked-by: Gaetan Rivet Thanks, -- Gaëtan Rivet 6WIND