DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Morten Brørup" <mb@smartsharesystems.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf: add bulk free function
Date: Wed, 11 Sep 2019 13:33:13 +0200	[thread overview]
Message-ID: <20190911113313.5nrcjvtm5dgi2r76@platinum> (raw)
In-Reply-To: <20190911121834.4ec73590@xps13>

Hi,

On Wed, Sep 11, 2019 at 12:18:34PM +0100, Stephen Hemminger wrote:
> On Wed, 11 Sep 2019 09:19:08 +0000
> Morten Brørup <mb@smartsharesystems.com> wrote:
> 
> > Add function for freeing a bulk of mbufs.
> > 
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> > ---
> >  lib/librte_mbuf/rte_mbuf.h | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index 98225ec80..f2e174da1 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -1907,6 +1907,23 @@ static inline void rte_pktmbuf_free(struct rte_mbuf *m)
> >  	}
> >  }
> >  
> > +/**
> > + * Free a bulk of mbufs back into their original mempool.
> > + *
> > + *  @param mbufs
> > + *    Array of pointers to mbufs
> > + *  @param count
> > + *    Array size
> > + */
> > +static inline void
> > +rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, unsigned count)
> > +{
> > +	unsigned idx = 0;
> > +
> > +	for (idx = 0; idx < count; idx++)
> > +		rte_pktmbuf_free(mbufs[idx]);
> > +}
> > +
> 
> You can optimize this to use mempool bulk put operation.

A bulk free for mbuf is not as simple as a bulk mempool put, because
of indirect mbufs, and because mbufs may return in different mempools.

Morten, do you have more details about why do you need such a function?

Thanks,
Olivier

  parent reply	other threads:[~2019-09-11 11:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11  9:19 Morten Brørup
2019-09-11 11:18 ` Stephen Hemminger
2019-09-11 11:29   ` Van Haaren, Harry
2019-09-11 11:41     ` Ananyev, Konstantin
2019-09-15  9:07       ` Morten Brørup
2019-09-15  9:24       ` Morten Brørup
2019-09-11 11:33   ` Olivier Matz [this message]
2019-09-11 11:39     ` Stephen Hemminger
2019-09-11 12:14     ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190911113313.5nrcjvtm5dgi2r76@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).