From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3118A2EEB for ; Thu, 12 Sep 2019 14:43:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AAC61E9CC; Thu, 12 Sep 2019 14:43:12 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 914BF1E9C1 for ; Thu, 12 Sep 2019 14:43:10 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2019 05:43:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,497,1559545200"; d="scan'208";a="186119296" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by fmsmga007.fm.intel.com with ESMTP; 12 Sep 2019 05:43:08 -0700 Date: Thu, 12 Sep 2019 20:40:49 +0800 From: Ye Xiaolong To: David Marchand Cc: Eelco Chaudron , Beilei Xing , Qi Zhang , dev Message-ID: <20190912124049.GA71525@intel.com> References: <8daee65a8edeae439ba9c2542877744b5be53684.1568284682.git.echaudro@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/12, David Marchand wrote: >On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron wrote: >> >> When receiving the unsupported AQ messages, it's taken as an >> error. It's not appropriate and triggers too much unnecessary print. >> >> This commit is similar to commit e130425300b0 ("net/i40e: downgrade >> unnecessary error log") which made the same change for the PF instance. >> >> Signed-off-by: Eelco Chaudron >> --- >> drivers/net/i40e/i40e_ethdev_vf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c >> index c77b30c54..7b1d485c6 100644 >> --- a/drivers/net/i40e/i40e_ethdev_vf.c >> +++ b/drivers/net/i40e/i40e_ethdev_vf.c >> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev) >> } >> break; >> default: >> - PMD_DRV_LOG(ERR, "Request %u is not supported yet", >> + PMD_DRV_LOG(DEBUG, "Request %u is not supported yet", >> aq_opc); >> break; >> } >> -- >> 2.18.1 >> > >Reviewed-by: David Marchand > > >-- >David Marchand Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel.