From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8641FA2EEB for ; Fri, 13 Sep 2019 11:54:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52F741EFB8; Fri, 13 Sep 2019 11:54:30 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B87B21EF8E for ; Fri, 13 Sep 2019 11:54:28 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2019 02:54:27 -0700 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="360719918" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2019 02:54:26 -0700 Date: Fri, 13 Sep 2019 10:54:23 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: bluca@debian.org, dev@dpdk.org Message-ID: <20190913095422.GB1921@bricha3-MOBL.ger.corp.intel.com> References: <20190913073425.13363-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190913073425.13363-1-thomas@monjalon.net> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] devtools: fix check of ccache for meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 13, 2019 at 09:34:25AM +0200, Thomas Monjalon wrote: > The meson build test fails if ccache is not available. > The use of ccache must be optional. > And if used, the compiler to check is the last word of $CC. > > Fixes: e0ae780e6569 ("devtools: test compiler availability only once") > > Signed-off-by: Thomas Monjalon > > --- > > This script is failing now because a real check of ccache availability > is done in commit e0ae780e6569. > It was not failing before, which means $CC is not used by meson? $CC is used, otherwise we wouldn't be able to do any clang builds. :-) I think what used to happen with earlier versions of the script was that large chunks of the builds used to be skipped if ccache wasn't available, i.e. I think it used to just do the "default" build and skip the regular clang/gcc builds as those were where we checked for compiler presence. [NOTE: it's been a while since I ran this on a system without ccache and I never got to fixing it when I did encounter one - installing ccache was always the easier step. :-)]