* [dpdk-dev] [PATCH] doc: virtio MAC/VLAN filtering is best effort
@ 2019-09-18 5:00 Tiwei Bie
2019-09-27 9:38 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Tiwei Bie @ 2019-09-18 5:00 UTC (permalink / raw)
To: maxime.coquelin, zhihong.wang, john.mcnamara, marko.kovacevic, dev
Explicitly document that the MAC/VLAN filtering in virtio
is best effort to help users understand why unwanted packets
could still arrive.
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
doc/guides/nics/virtio.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
index bd0116176..fb378a4b9 100644
--- a/doc/guides/nics/virtio.rst
+++ b/doc/guides/nics/virtio.rst
@@ -56,7 +56,7 @@ In this release, the virtio PMD driver provides the basic functionality of packe
* Features of mac/vlan filter are supported, negotiation with vhost/backend are needed to support them.
When backend can't support vlan filter, virtio app on guest should not enable vlan filter in order
to make sure the virtio port is configured correctly. E.g. do not specify '--enable-hw-vlan' in testpmd
- command line.
+ command line. Note that, mac/vlan filter is best effort: unwanted packets could still arrive.
* "RTE_PKTMBUF_HEADROOM" should be defined
no less than "sizeof(struct virtio_net_hdr_mrg_rxbuf)", which is 12 bytes when mergeable or
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] doc: virtio MAC/VLAN filtering is best effort
2019-09-18 5:00 [dpdk-dev] [PATCH] doc: virtio MAC/VLAN filtering is best effort Tiwei Bie
@ 2019-09-27 9:38 ` Maxime Coquelin
2019-09-27 9:52 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2019-09-27 9:38 UTC (permalink / raw)
To: Tiwei Bie, zhihong.wang, john.mcnamara, marko.kovacevic, dev
On 9/18/19 7:00 AM, Tiwei Bie wrote:
> Explicitly document that the MAC/VLAN filtering in virtio
> is best effort to help users understand why unwanted packets
> could still arrive.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> doc/guides/nics/virtio.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: virtio MAC/VLAN filtering is best effort
2019-09-27 9:38 ` Maxime Coquelin
@ 2019-09-27 9:52 ` Maxime Coquelin
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2019-09-27 9:52 UTC (permalink / raw)
To: Tiwei Bie, zhihong.wang, john.mcnamara, marko.kovacevic, dev
On 9/27/19 11:38 AM, Maxime Coquelin wrote:
>
>
> On 9/18/19 7:00 AM, Tiwei Bie wrote:
>> Explicitly document that the MAC/VLAN filtering in virtio
>> is best effort to help users understand why unwanted packets
>> could still arrive.
>>
>> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>> ---
>> doc/guides/nics/virtio.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Thanks,
> Maxime
>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-27 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-18 5:00 [dpdk-dev] [PATCH] doc: virtio MAC/VLAN filtering is best effort Tiwei Bie
2019-09-27 9:38 ` Maxime Coquelin
2019-09-27 9:52 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).