From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CCCAA0613 for ; Wed, 25 Sep 2019 16:48:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EA8A1BF28; Wed, 25 Sep 2019 16:48:29 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E596B1BF27 for ; Wed, 25 Sep 2019 16:48:27 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 07:48:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,548,1559545200"; d="scan'208";a="340427326" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.73]) by orsmga004.jf.intel.com with ESMTP; 25 Sep 2019 07:48:25 -0700 Date: Wed, 25 Sep 2019 22:45:38 +0800 From: Tiwei Bie To: Jin Yu Cc: dev@dpdk.org, changpeng.liu@intel.com, maxime.coquelin@redhat.com, zhihong.wang@intel.com Message-ID: <20190925144538.GA25789@___> References: <20190917145234.16951> <20190920120102.29828-1-jin.yu@intel.com> <20190920120102.29828-11-jin.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190920120102.29828-11-jin.yu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v7 10/10] vhost: add vhost-user-blk example which support inflight X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 20, 2019 at 08:01:02PM +0800, Jin Yu wrote: > A vhost-user-blk example that support inflight feature. It uses the > new APIs that introduced in the first patch, so It can show how there s/It/it/ s/there/these/ > APIs work to support inflight feature. > > Signed-off-by: Jin Yu > --- > V1 - add the case. > V2 - add the rte_vhost prefix. > V3 - add packed ring support > --- > examples/vhost_blk/Makefile | 67 ++ > examples/vhost_blk/blk.c | 125 +++ > examples/vhost_blk/blk_spec.h | 95 ++ > examples/vhost_blk/meson.build | 20 + > examples/vhost_blk/vhost_blk.c | 1313 +++++++++++++++++++++++++ > examples/vhost_blk/vhost_blk.h | 116 +++ > examples/vhost_blk/vhost_blk_compat.c | 195 ++++ > 7 files changed, 1931 insertions(+) I met some build issues when trying this example. examples/vhost_blk/vhost_blk.c: In function ‘descriptor_get_next_packed’: examples/vhost_blk/vhost_blk.c:71:21: error: invalid use of undefined type ‘struct vring_packed_desc’ if (vq->desc_packed[*idx % vq->size].flags & VIRTQ_DESC_F_NEXT) { ^ examples/vhost_blk/vhost_blk.c:71:21: error: dereferencing pointer to incomplete type ‘struct vring_packed_desc’ examples/vhost_blk/vhost_blk.c:73:26: error: invalid use of undefined type ‘struct vring_packed_desc’ return &vq->desc_packed[*idx % vq->size]; ^ examples/vhost_blk/vhost_blk.c: In function ‘inflight_submit_completion_packed’: examples/vhost_blk/vhost_blk.c:165:2: warning: ‘rte_vhost_set_last_inflight_io_packed’ is deprecated: Symbol is not yet part of stable ABI [-Wdeprecated-declarations] ret = rte_vhost_set_last_inflight_io_packed(ctrlr->bdev->vid, q_idx, ^~~ In file included from examples/vhost_blk/vhost_blk.c:17:0: x86_64-native-linuxapp-gcc/include/rte_vhost.h:810:1: note: declared here rte_vhost_set_last_inflight_io_packed(int vid, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ...