From: David Christensen <drc@linux.vnet.ibm.com>
To: anatoly.burakov@intel.com
Cc: dev@dpdk.org, David Christensen <drc@linux.vnet.ibm.com>
Subject: [dpdk-dev] [PATCH] eal:ppc: fix incorrect ifdef for ppc_64
Date: Wed, 25 Sep 2019 14:42:23 -0700 [thread overview]
Message-ID: <20190925214223.79362-1-drc@linux.vnet.ibm.com> (raw)
An ifdef present in eal_memory.c references "RTE_ARCH_PPC64" when
it should actually use "RTE_ARCH_PPC_64". Simple testing revealed
that both the PPC_64 and non-PPC_64 versions of the code involved
work, but the PPC_64 version of the code is retained to be
consistent with other instances in the same file where mmapped
memory is accessed in reverse order on Power platforms.
Fixes: 66cc45e ("mem: replace memseg with memseg lists")
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
lib/librte_eal/linux/eal/eal_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linux/eal/eal_memory.c b/lib/librte_eal/linux/eal/eal_memory.c
index 1c089a1ef..1bbdd8a29 100644
--- a/lib/librte_eal/linux/eal/eal_memory.c
+++ b/lib/librte_eal/linux/eal/eal_memory.c
@@ -688,7 +688,7 @@ remap_segment(struct hugepage_file *hugepages, int seg_start, int seg_end)
return -1;
}
-#ifdef RTE_ARCH_PPC64
+#ifdef RTE_ARCH_PPC_64
/* for PPC64 we go through the list backwards */
for (cur_page = seg_end - 1; cur_page >= seg_start;
cur_page--, ms_idx++) {
--
2.18.1
next reply other threads:[~2019-09-25 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 21:42 David Christensen [this message]
2019-09-26 7:43 ` Ferruh Yigit
2019-10-24 9:36 ` David Marchand
2019-10-16 15:16 ` David Marchand
2019-10-16 20:45 ` David Christensen
2019-10-17 16:18 ` Burakov, Anatoly
2019-10-17 16:35 ` David Marchand
2019-10-17 16:55 ` David Christensen
2019-10-24 7:40 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925214223.79362-1-drc@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).