From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32B5CA0613 for ; Thu, 26 Sep 2019 19:15:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 892592C58; Thu, 26 Sep 2019 19:15:23 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 219F32C57 for ; Thu, 26 Sep 2019 19:15:22 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id i30so1934154pgl.0 for ; Thu, 26 Sep 2019 10:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ioccIWW1S6XBYVZLy/M/q3gknHV6wq/4VO4GJKQS8o8=; b=M9P+M1uX2NgpefTfjCFkA2fKbJL48wnHrbFJnCn8B90Uldb93pdIxJOtlPc/apL7Ty R6s7dC3GV71t3/66+CXWRWDgFDD0qTv+htGh1ZooSiUCelphopU6RDAyzkr1kAODi9Mr 4IFoy5kjo0W6oVIBunnT7fJuNc3w5kp+3TQwjNMk0K4T7rE3PyxtLmHIKUtZhLD4PXHz Yr+HlSD81V7V+IaXWbxx+NcynMkfhYoTTOoHd7oRKrTT5PouZXXKPEduMVjalA1gAveJ IgGqlNXsrRMCfi0H7aTS5fzSkCqtYCU8xJYfi0bdh1DzbQ6uBNaUT7quzDu4CsY3hIz8 EIRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ioccIWW1S6XBYVZLy/M/q3gknHV6wq/4VO4GJKQS8o8=; b=nigsdQc+8eT44aUKNV6FkN60sAE7XKXU7gE6IHNWeTeVa+54YCjXO1+23FwMqIcMH9 KPbrKTnk2sNz54K4WbHGG0Dz47CqdoxYzpL08NG+1jvwuRE9qGlC3Ppr4H+5qfJn6GvG 4fKjX1qpD6q3Z4pd9thpedlet7W+sTaf+gO7gJz0AmSmiYywv93tNIzDJpR63XYiHkFR dnSwJJWadwGjKiw9Pi7TFnG4OmqbqWYh8VTJPpZCLF/0iaAJ8zD3cHRJYFwMGcAKaP3r pDRQDVqJcz7udzeY7Q+if+xyWq+VSh+UOOJdnoLTI7Y4vCtb8XUSMrHDjJfmR2FkaH9K pJVQ== X-Gm-Message-State: APjAAAUTyzNJOl8Ctz73kJ3ftyIgppk2PCH9ylj4TsPiB7w8RqMI2uxg K4l7GyZ4RWz+kU4ofgZBH8jpcw== X-Google-Smtp-Source: APXvYqz43UV7CRRSiciEkMxsJ9E8Ai8rahymxnQ4sui6Wmao9mZbUBQqzajmya/SOIPYOQ0E3BwWXw== X-Received: by 2002:a63:e5c:: with SMTP id 28mr4462984pgo.133.1569518120809; Thu, 26 Sep 2019 10:15:20 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y2sm3189746pfe.126.2019.09.26.10.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2019 10:15:20 -0700 (PDT) Date: Thu, 26 Sep 2019 10:15:17 -0700 From: Stephen Hemminger To: "Wang, Haiyue" Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "Ye, Xiaolong" , "Kinsella, Ray" , "Iremonger, Bernard" , "Sun, Chenmin" Message-ID: <20190926101517.505ab45c@hermes.lan> In-Reply-To: References: <20190926114818.91063-1-haiyue.wang@intel.com> <20190926085728.51161998@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 26 Sep 2019 16:36:09 +0000 "Wang, Haiyue" wrote: > Hi Stephen, >=20 > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Thursday, September 26, 2019 23:57 > > To: Wang, Haiyue > > Cc: dev@dpdk.org; Yigit, Ferruh ; Ye, Xiaolong = ; > > Kinsella, Ray ; Iremonger, Bernard ; Sun, Chenmin > > > > Subject: Re: [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet burst mode info= rmation > >=20 > > On Thu, 26 Sep 2019 19:48:14 +0800 > > Haiyue Wang wrote: > > =20 > > > RFCv3 -> v1: > > > https://patchwork.dpdk.org/patch/59103/ > > > https://patchwork.dpdk.org/patch/59104/ > > > https://patchwork.dpdk.org/patch/59105/ > > > https://patchwork.dpdk.org/patch/59106/ > > > 1). Use the function 'rte_bsf64' to iterate the options for > > > getting the name. > > > > > > Haiyue Wang (4): > > > ethdev: add the API for getting burst mode information > > > net/i40e: support to get the Rx/Tx burst mode > > > net/ice: support to get the Rx/Tx burst mode > > > app/testpmd: show the Rx/Tx burst mode description > > > > > > app/test-pmd/config.c | 29 +++++++++ > > > doc/guides/rel_notes/release_19_11.rst | 9 +++ > > > drivers/net/i40e/i40e_ethdev.c | 2 + > > > drivers/net/i40e/i40e_ethdev.h | 4 ++ > > > drivers/net/i40e/i40e_rxtx.c | 72 +++++++++++++++++++++ > > > drivers/net/ice/ice_ethdev.c | 2 + > > > drivers/net/ice/ice_rxtx.c | 54 ++++++++++++++++ > > > drivers/net/ice/ice_rxtx.h | 4 ++ > > > lib/librte_ethdev/rte_ethdev.c | 75 ++++++++++++++++++++++ > > > lib/librte_ethdev/rte_ethdev.h | 82 ++++++++++++++++++++++= ++ > > > lib/librte_ethdev/rte_ethdev_core.h | 5 ++ > > > lib/librte_ethdev/rte_ethdev_version.map | 5 ++ > > > 12 files changed, 343 insertions(+) > > > =20 > >=20 > > A couple of meta comments: > > 1) Could this be part of dev_info_get somehow? > > =20 >=20 > https://patchwork.dpdk.org/patch/57624/ > 'Think of a better way that doesn't break ABI.' ;-) That comment was made relative to 19.08, but 19.11 is the time where API/ABI breakage is allowed. =20 > > 2) Why should application care? Is this just a test hook? =20 >=20 > https://patches.dpdk.org/cover/57623/ > This is from FD.io VPP's bug, and finally, we come out > this API for application accessing the burst mode information. > It can be used as a simple trace or something like performance > analysis like why slow ? Not in vector, anyway, application can > get this burst mode information now, not just open PMD debug log > level. =46rom an architecture perspective, diagnostics are good but VPP is probably taking that too far. It is possible to expose local symbols if they want to keep using dlsym() by adjusting linker flags. It is more that VPP is stripping everything. Since VPP has chosen to go their own way is fixable inside VPP without changing DPDK. Also, long term VPP is going away from using DPDK drivers. Probably soon they will have their own drivers for i40e and ice anyway. The basis of my concern is that this is one of those kind of API's that creates long term technical debt around supporting it as other things change.